zsp/everything-claude-code
1
0
Fork 0
mirror of https://github.com/affaan-m/everything-claude-code.git synced 2026-04-05 08:43:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve stop hooks without plugin root

Browse Source
This commit is contained in:
Affaan Mustafa
2026-03-29 21:24:03 -04:00
parent dd675d4258
commit 284d2995ba
3 changed files with 71 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tests/integration/hooks.test.js
View File

@@ -179,6 +179,17 @@ function cleanupTestDir(testDir) {
fs.rmSync(testDir, { recursive: true, force: true });
}
function stagePluginRuntime(homeDir, relativePaths) {
const pluginRoot = path.join(homeDir, '.claude', 'plugins', 'everything-claude-code');
for (const relativePath of relativePaths) {
const sourcePath = path.join(REPO_ROOT, relativePath);
const destinationPath = path.join(pluginRoot, relativePath);
fs.mkdirSync(path.dirname(destinationPath), { recursive: true });
fs.copyFileSync(sourcePath, destinationPath);
}
return pluginRoot;
}
function getHookCommandByDescription(hooks, lifecycle, descriptionText) {
const hookGroup = hooks.hooks[lifecycle]?.find(
entry => entry.description && entry.description.includes(descriptionText)
@@ -267,6 +278,35 @@ async function runTests() {
assert.strictEqual(payload.hookSpecificOutput.hookEventName, 'SessionStart');
})) passed++; else failed++;
if (await asyncTest('Stop hook resolves plugin root when CLAUDE_PLUGIN_ROOT is unset', async () => {
const homeDir = createTestDir();
try {
stagePluginRuntime(homeDir, [
path.join('scripts', 'hooks', 'run-with-flags.js'),
path.join('scripts', 'hooks', 'check-console-log.js'),
path.join('scripts', 'lib', 'hook-flags.js'),
path.join('scripts', 'lib', 'utils.js'),
]);
const hookCommand = getHookCommandByDescription(
hooks,
'Stop',
'Check for console.log in modified files after each response'
);
const result = await runHookCommand(hookCommand, {}, {
HOME: homeDir,
CLAUDE_PLUGIN_ROOT: '',
});
assert.strictEqual(result.code, 0, `Expected stop hook to exit 0, got ${result.code}: ${result.stderr}`);
assert.ok(!result.stderr.includes("Cannot find module '/scripts/hooks/run-with-flags.js'"), 'Should not resolve to the filesystem root');
assert.ok(!result.stderr.includes('could not resolve ECC plugin root'), 'Should discover the plugin root from known install paths');
} finally {
cleanupTestDir(homeDir);
}
})) passed++; else failed++;
if (await asyncTest('PreCompact hook logs to stderr', async () => {
const result = await runHookWithInput(path.join(scriptsDir, 'pre-compact.js'), {});
assert.ok(result.stderr.includes('[PreCompact]'), 'Should output to stderr with prefix');