test: add Round 104 edge-case tests (detectFromLockFile null, resolveSessionAlias traversal, whitespace notes)

- detectFromLockFile(null): throws TypeError — no input validation before
  path.join (package-manager.js:95)
- resolveSessionAlias('../etc/passwd'): returns path-traversal input unchanged
  when alias lookup fails, documenting the passthrough behavior
- parseSessionMetadata with whitespace-only notes: trim() → "" → hasNotes=false,
  whitespace-only notes treated as absent

Total tests: 872 (all passing)
This commit is contained in:
Affaan Mustafa
2026-02-13 16:45:47 -08:00
parent 45a0b62fcb
commit 332d0f444b
3 changed files with 62 additions and 0 deletions

View File

@@ -1689,6 +1689,34 @@ src/main.ts
'Second unchecked item');
})) passed++; else failed++;
// ── Round 104: parseSessionMetadata with whitespace-only notes section ──
console.log('\nRound 104: parseSessionMetadata (whitespace-only notes — trim reduces to empty):');
if (test('parseSessionMetadata treats whitespace-only notes as absent (trim → empty string → falsy)', () => {
// session-manager.js line 139: `metadata.notes = notesSection[1].trim()` — when the
// Notes section heading exists but only contains whitespace/newlines, trim() returns "".
// Then getSessionStats line 178: `hasNotes: !!metadata.notes` — `!!""` is `false`.
// So a notes section with only whitespace is treated as "no notes."
const content = `# Session
### Notes for Next Session
\t
### Context to Load
\`\`\`
file.ts
\`\`\`
`;
const meta = sessionManager.parseSessionMetadata(content);
assert.strictEqual(meta.notes, '',
'Whitespace-only notes should trim to empty string');
// Verify getSessionStats reports hasNotes as false
const stats = sessionManager.getSessionStats(content);
assert.strictEqual(stats.hasNotes, false,
'hasNotes should be false because !!"" is false (whitespace-only notes treated as absent)');
assert.strictEqual(stats.hasContext, true,
'hasContext should be true (context section has actual content)');
})) passed++; else failed++;
// Summary
console.log(`\nResults: Passed: ${passed}, Failed: ${failed}`);
process.exit(failed > 0 ? 1 : 0);