zsp/everything-claude-code
1
0
Fork 0
mirror of https://github.com/affaan-m/everything-claude-code.git synced 2026-03-30 13:43:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: address code review findings from cubic-dev-ai

Browse Source 
- Fix path traversal regex prefix confusion in perl-security skill
  - Revert v1.4.0 changelog entry (Perl not part of that release)
  - Rename $a/$b to $x/$y to avoid shadowing sort globals
  - Replace return undef with bare return per perlcritic rules
This commit is contained in:
Necip Sunmaz
2026-03-09 06:46:49 +03:00
committed by Affaan Mustafa
parent b2a7bae5db
commit 36bcf20588
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@@ -110,7 +110,7 @@ This repo is the raw code only. The guides explain everything.
- **Interactive installation wizard** — New `configure-ecc` skill provides guided setup with merge/overwrite detection - **Interactive installation wizard** — New `configure-ecc` skill provides guided setup with merge/overwrite detection
- **PM2 & multi-agent orchestration** — 6 new commands (`/pm2`, `/multi-plan`, `/multi-execute`, `/multi-backend`, `/multi-frontend`, `/multi-workflow`) for managing complex multi-service workflows - **PM2 & multi-agent orchestration** — 6 new commands (`/pm2`, `/multi-plan`, `/multi-execute`, `/multi-backend`, `/multi-frontend`, `/multi-workflow`) for managing complex multi-service workflows
- **Multi-language rules architecture** — Rules restructured from flat files into `common/` + `typescript/` + `python/` + `golang/` + `perl/` directories. Install only the languages you need - **Multi-language rules architecture** — Rules restructured from flat files into `common/` + `typescript/` + `python/` + `golang/` directories. Install only the languages you need
- **Chinese (zh-CN) translations** — Complete translation of all agents, commands, skills, and rules (80+ files) - **Chinese (zh-CN) translations** — Complete translation of all agents, commands, skills, and rules (80+ files)
- **GitHub Sponsors support** — Sponsor the project via GitHub Sponsors - **GitHub Sponsors support** — Sponsor the project via GitHub Sponsors
- **Enhanced CONTRIBUTING.md** — Detailed PR templates for each contribution type - **Enhanced CONTRIBUTING.md** — Detailed PR templates for each contribution type

8
skills/perl-patterns/SKILL.md
View File

@@ -157,14 +157,14 @@ sub fetch_user($id) {
```perl ```perl
use v5.40; use v5.40;
sub divide($a, $b) { sub divide($x, $y) {
try { try {
die "Division by zero" if $b == 0; die "Division by zero" if $y == 0;
return $a / $b; return $x / $y;
} }
catch ($e) { catch ($e) {
warn "Error: $e"; warn "Error: $e";
return undef; return;
} }
} }
``` ```

2
skills/perl-security/SKILL.md
View File

@@ -197,7 +197,7 @@ sub safe_path($base_dir, $user_path) {
// die "Path does not exist\n"; // die "Path does not exist\n";
my $base_real = realpath($base_dir) my $base_real = realpath($base_dir)
// die "Base dir does not exist\n"; // die "Base dir does not exist\n";
die "Path traversal blocked\n" unless $real =~ /^\Q$base_real\E/; die "Path traversal blocked\n" unless $real =~ /^\Q$base_real\E\//;
return $real; return $real;
} }
``` ```