From 4d3033eb64f65bd44d228a6d27fc106661cce67d Mon Sep 17 00:00:00 2001 From: zomia Date: Thu, 14 May 2026 08:40:36 +0900 Subject: [PATCH] docs: fix cp -r flatten install instructions that silently overwrite rules MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The configure-ecc skill (English source) and ja-JP top-level README plus its configure-ecc translation documented `cp -r ...//* /rules/` for installing rule directories. rules/README.md explicitly warns against this form because: - Common and language-specific directories contain same-named files (coding-style.md, testing.md, patterns.md, hooks.md, security.md). Flattening makes each language overwrite the previous and common. - The relative `../common/.md` references in language rule files break when common/ is no longer a sibling directory. This is silent — the user gets only the last language's rules with no error message. Replace with the directory-form copy already documented in rules/README.md: cp -r .../ /rules/ Scope: English source + ja-JP. Closes #1879. Other locale translations (zh-CN, ko-KR, pt-BR, tr) carry the same pattern and can follow up as separate PRs to keep this change reviewable. --- docs/ja-JP/README.md | 28 ++++++++++++------------ docs/ja-JP/skills/configure-ecc/SKILL.md | 12 +++++----- skills/configure-ecc/SKILL.md | 12 +++++----- 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/docs/ja-JP/README.md b/docs/ja-JP/README.md index 0a99c37e..06c5f8f1 100644 --- a/docs/ja-JP/README.md +++ b/docs/ja-JP/README.md @@ -122,12 +122,12 @@ git clone https://github.com/affaan-m/everything-claude-code.git # 共通ルールをインストール（必須） -cp -r everything-claude-code/rules/common/* ~/.claude/rules/ +cp -r everything-claude-code/rules/common ~/.claude/rules/common # 言語固有ルールをインストール（スタックを選択） -cp -r everything-claude-code/rules/typescript/* ~/.claude/rules/ -cp -r everything-claude-code/rules/python/* ~/.claude/rules/ -cp -r everything-claude-code/rules/golang/* ~/.claude/rules/ +cp -r everything-claude-code/rules/typescript ~/.claude/rules/typescript +cp -r everything-claude-code/rules/python ~/.claude/rules/python +cp -r everything-claude-code/rules/golang ~/.claude/rules/golang ``` ### ステップ3：使用開始 @@ -462,15 +462,15 @@ Duplicate hook file detected: ./hooks/hooks.json is already resolved to a loaded > > # オプション A：ユーザーレベルルール（すべてのプロジェクトに適用） > mkdir -p ~/.claude/rules -> cp -r everything-claude-code/rules/common/* ~/.claude/rules/ -> cp -r everything-claude-code/rules/typescript/* ~/.claude/rules/ # スタックを選択 -> cp -r everything-claude-code/rules/python/* ~/.claude/rules/ -> cp -r everything-claude-code/rules/golang/* ~/.claude/rules/ +> cp -r everything-claude-code/rules/common ~/.claude/rules/common +> cp -r everything-claude-code/rules/typescript ~/.claude/rules/typescript # スタックを選択 +> cp -r everything-claude-code/rules/python ~/.claude/rules/python +> cp -r everything-claude-code/rules/golang ~/.claude/rules/golang > > # オプション B：プロジェクトレベルルール（現在のプロジェクトのみ） > mkdir -p .claude/rules -> cp -r everything-claude-code/rules/common/* .claude/rules/ -> cp -r everything-claude-code/rules/typescript/* .claude/rules/ # スタックを選択 +> cp -r everything-claude-code/rules/common .claude/rules/common +> cp -r everything-claude-code/rules/typescript .claude/rules/typescript # スタックを選択 > ``` --- @@ -487,10 +487,10 @@ git clone https://github.com/affaan-m/everything-claude-code.git cp everything-claude-code/agents/*.md ~/.claude/agents/ # ルール（共通 + 言語固有）をコピー -cp -r everything-claude-code/rules/common/* ~/.claude/rules/ -cp -r everything-claude-code/rules/typescript/* ~/.claude/rules/ # スタックを選択 -cp -r everything-claude-code/rules/python/* ~/.claude/rules/ -cp -r everything-claude-code/rules/golang/* ~/.claude/rules/ +cp -r everything-claude-code/rules/common ~/.claude/rules/common +cp -r everything-claude-code/rules/typescript ~/.claude/rules/typescript # スタックを選択 +cp -r everything-claude-code/rules/python ~/.claude/rules/python +cp -r everything-claude-code/rules/golang ~/.claude/rules/golang # コマンドをコピー cp everything-claude-code/commands/*.md ~/.claude/commands/ diff --git a/docs/ja-JP/skills/configure-ecc/SKILL.md b/docs/ja-JP/skills/configure-ecc/SKILL.md index 9c289eb4..b8b73d5f 100644 --- a/docs/ja-JP/skills/configure-ecc/SKILL.md +++ b/docs/ja-JP/skills/configure-ecc/SKILL.md @@ -169,13 +169,13 @@ Options: インストールを実行： ```bash -# 共通ルール（rules/ にフラットコピー） -cp -r $ECC_ROOT/rules/common/* $TARGET/rules/ +# 共通ルール +cp -r $ECC_ROOT/rules/common $TARGET/rules/common -# 言語固有のルール（rules/ にフラットコピー） -cp -r $ECC_ROOT/rules/typescript/* $TARGET/rules/ # 選択された場合 -cp -r $ECC_ROOT/rules/python/* $TARGET/rules/ # 選択された場合 -cp -r $ECC_ROOT/rules/golang/* $TARGET/rules/ # 選択された場合 +# 言語固有のルール（言語別ディレクトリを保持） +cp -r $ECC_ROOT/rules/typescript $TARGET/rules/typescript # 選択された場合 +cp -r $ECC_ROOT/rules/python $TARGET/rules/python # 選択された場合 +cp -r $ECC_ROOT/rules/golang $TARGET/rules/golang # 選択された場合 ``` **重要**: ユーザーが言語固有のルールを選択したが、共通ルールを選択しなかった場合、警告します： diff --git a/skills/configure-ecc/SKILL.md b/skills/configure-ecc/SKILL.md index 50f9ad86..679ae7fd 100644 --- a/skills/configure-ecc/SKILL.md +++ b/skills/configure-ecc/SKILL.md @@ -234,13 +234,13 @@ Options: Execute installation: ```bash -# Common rules (flat copy into rules/) -cp -r $ECC_ROOT/rules/common/* $TARGET/rules/ +# Common rules +cp -r $ECC_ROOT/rules/common $TARGET/rules/common -# Language-specific rules (flat copy into rules/) -cp -r $ECC_ROOT/rules/typescript/* $TARGET/rules/ # if selected -cp -r $ECC_ROOT/rules/python/* $TARGET/rules/ # if selected -cp -r $ECC_ROOT/rules/golang/* $TARGET/rules/ # if selected +# Language-specific rules (preserve per-language directories) +cp -r $ECC_ROOT/rules/typescript $TARGET/rules/typescript # if selected +cp -r $ECC_ROOT/rules/python $TARGET/rules/python # if selected +cp -r $ECC_ROOT/rules/golang $TARGET/rules/golang # if selected ``` **Important**: If the user selects any language-specific rules but NOT common rules, warn them: