mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-04-06 01:03:32 +08:00
fix: add missing validation in renameAlias, add 6 tests
renameAlias was missing length (>128), reserved name, and empty string validation that setAlias enforced. This inconsistency allowed renaming aliases to reserved names like 'list' or 'delete'. Also adds tests for: - renameAlias empty string, reserved name, and length limit - validate-skills whitespace-only SKILL.md rejection - validate-rules whitespace-only file and recursive subdirectory scan
This commit is contained in:
@@ -282,6 +282,30 @@ function runTests() {
|
||||
assert.strictEqual(result.success, false);
|
||||
})) passed++; else failed++;
|
||||
|
||||
if (test('rejects rename to empty string', () => {
|
||||
resetAliases();
|
||||
aliases.setAlias('valid', '/path');
|
||||
const result = aliases.renameAlias('valid', '');
|
||||
assert.strictEqual(result.success, false);
|
||||
assert.ok(result.error.includes('empty'));
|
||||
})) passed++; else failed++;
|
||||
|
||||
if (test('rejects rename to reserved name', () => {
|
||||
resetAliases();
|
||||
aliases.setAlias('valid', '/path');
|
||||
const result = aliases.renameAlias('valid', 'list');
|
||||
assert.strictEqual(result.success, false);
|
||||
assert.ok(result.error.includes('reserved'));
|
||||
})) passed++; else failed++;
|
||||
|
||||
if (test('rejects rename to name exceeding 128 chars', () => {
|
||||
resetAliases();
|
||||
aliases.setAlias('valid', '/path');
|
||||
const result = aliases.renameAlias('valid', 'a'.repeat(129));
|
||||
assert.strictEqual(result.success, false);
|
||||
assert.ok(result.error.includes('128'));
|
||||
})) passed++; else failed++;
|
||||
|
||||
// updateAliasTitle tests
|
||||
console.log('\nupdateAliasTitle:');
|
||||
|
||||
|
||||
Reference in New Issue
Block a user