fix: unblock unicode safety CI lint (#1017)

* fix: unblock unicode safety CI lint

* fix: unblock shared CI regressions
This commit is contained in:
Affaan Mustafa
2026-03-30 01:50:17 -04:00
committed by GitHub
parent cff28efb34
commit 8846210ca2
4 changed files with 66 additions and 22 deletions

View File

@@ -50,9 +50,7 @@ const writeModeSkip = new Set([
path.normalize('tests/scripts/check-unicode-safety.test.js'), path.normalize('tests/scripts/check-unicode-safety.test.js'),
]); ]);
const dangerousInvisibleRe = const emojiRe = /(?:\p{Extended_Pictographic}|\p{Regional_Indicator})/gu;
/[\u200B-\u200D\u2060\uFEFF\u202A-\u202E\u2066-\u2069\uFE00-\uFE0F\u{E0100}-\u{E01EF}]/gu;
const emojiRe = /[\p{Extended_Pictographic}\p{Regional_Indicator}]/gu;
const allowedSymbolCodePoints = new Set([ const allowedSymbolCodePoints = new Set([
0x00A9, 0x00A9,
0x00AE, 0x00AE,
@@ -106,9 +104,31 @@ function isAllowedEmojiLikeSymbol(char) {
return allowedSymbolCodePoints.has(char.codePointAt(0)); return allowedSymbolCodePoints.has(char.codePointAt(0));
} }
function isDangerousInvisibleCodePoint(codePoint) {
return (
(codePoint >= 0x200B && codePoint <= 0x200D) ||
codePoint === 0x2060 ||
codePoint === 0xFEFF ||
(codePoint >= 0x202A && codePoint <= 0x202E) ||
(codePoint >= 0x2066 && codePoint <= 0x2069) ||
(codePoint >= 0xFE00 && codePoint <= 0xFE0F) ||
(codePoint >= 0xE0100 && codePoint <= 0xE01EF)
);
}
function stripDangerousInvisibleChars(text) {
let next = '';
for (const char of text) {
if (!isDangerousInvisibleCodePoint(char.codePointAt(0))) {
next += char;
}
}
return next;
}
function sanitizeText(text) { function sanitizeText(text) {
let next = text; let next = text;
next = next.replace(dangerousInvisibleRe, ''); next = stripDangerousInvisibleChars(next);
for (const [pattern, replacement] of targetedReplacements) { for (const [pattern, replacement] of targetedReplacements) {
next = next.replace(pattern, replacement); next = next.replace(pattern, replacement);
@@ -146,6 +166,28 @@ function collectMatches(text, regex, kind) {
return matches; return matches;
} }
function collectDangerousInvisibleMatches(text) {
const matches = [];
let index = 0;
for (const char of text) {
const codePoint = char.codePointAt(0);
if (isDangerousInvisibleCodePoint(codePoint)) {
const { line, column } = lineAndColumn(text, index);
matches.push({
kind: 'dangerous-invisible',
char,
codePoint: `U+${codePoint.toString(16).toUpperCase()}`,
line,
column,
});
}
index += char.length;
}
return matches;
}
const changedFiles = []; const changedFiles = [];
const violations = []; const violations = [];
@@ -172,7 +214,7 @@ for (const filePath of listFiles(repoRoot)) {
} }
const fileViolations = [ const fileViolations = [
...collectMatches(text, dangerousInvisibleRe, 'dangerous-invisible'), ...collectDangerousInvisibleMatches(text),
...collectMatches(text, emojiRe, 'emoji'), ...collectMatches(text, emojiRe, 'emoji'),
]; ];

View File

@@ -116,8 +116,10 @@ if (
fs.mkdirSync(codexDir, { recursive: true }); fs.mkdirSync(codexDir, { recursive: true });
fs.writeFileSync(configPath, config); fs.writeFileSync(configPath, config);
const syncResult = runBash(syncScript, [], { HOME: homeDir, CODEX_HOME: codexDir }); const syncResult = runBash(syncScript, ['--update-mcp'], { HOME: homeDir, CODEX_HOME: codexDir });
assert.strictEqual(syncResult.status, 0, syncResult.stderr || syncResult.stdout); assert.strictEqual(syncResult.status, 0, `${syncResult.stdout}\n${syncResult.stderr}`);
const syncedConfig = fs.readFileSync(configPath, 'utf8');
assert.match(syncedConfig, /^\[mcp_servers\.context7\]$/m);
const checkResult = runBash(checkScript, [], { HOME: homeDir, CODEX_HOME: codexDir }); const checkResult = runBash(checkScript, [], { HOME: homeDir, CODEX_HOME: codexDir });
assert.strictEqual(checkResult.status, 0, checkResult.stderr || checkResult.stdout); assert.strictEqual(checkResult.status, 0, checkResult.stderr || checkResult.stdout);