mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-04-07 09:43:30 +08:00
fix: unblock unicode safety CI lint (#1017)
* fix: unblock unicode safety CI lint * fix: unblock shared CI regressions
This commit is contained in:
@@ -75,17 +75,17 @@ origin: auto-extracted
|
|||||||
|
|
||||||
**Guideline dimensions** (informing the verdict, not scored):
|
**Guideline dimensions** (informing the verdict, not scored):
|
||||||
|
|
||||||
- **Specificity & Actionability**: Contains code examples or commands that are immediately usable
|
- **Specificity & Actionability**: Contains code examples or commands that are immediately usable
|
||||||
- **Scope Fit**: Name, trigger conditions, and content are aligned and focused on a single pattern
|
- **Scope Fit**: Name, trigger conditions, and content are aligned and focused on a single pattern
|
||||||
- **Uniqueness**: Provides value not covered by existing skills (informed by checklist results)
|
- **Uniqueness**: Provides value not covered by existing skills (informed by checklist results)
|
||||||
- **Reusability**: Realistic trigger scenarios exist in future sessions
|
- **Reusability**: Realistic trigger scenarios exist in future sessions
|
||||||
|
|
||||||
6. **Verdict-specific confirmation flow**
|
6. **Verdict-specific confirmation flow**
|
||||||
|
|
||||||
- **Improve then Save**: Present the required improvements + revised draft + updated checklist/verdict after one re-evaluation; if the revised verdict is **Save**, save after user confirmation, otherwise follow the new verdict
|
- **Improve then Save**: Present the required improvements + revised draft + updated checklist/verdict after one re-evaluation; if the revised verdict is **Save**, save after user confirmation, otherwise follow the new verdict
|
||||||
- **Save**: Present save path + checklist results + 1-line verdict rationale + full draft → save after user confirmation
|
- **Save**: Present save path + checklist results + 1-line verdict rationale + full draft → save after user confirmation
|
||||||
- **Absorb into [X]**: Present target path + additions (diff format) + checklist results + verdict rationale → append after user confirmation
|
- **Absorb into [X]**: Present target path + additions (diff format) + checklist results + verdict rationale → append after user confirmation
|
||||||
- **Drop**: Show checklist results + reasoning only (no confirmation needed)
|
- **Drop**: Show checklist results + reasoning only (no confirmation needed)
|
||||||
|
|
||||||
7. Save / Absorb to the determined location
|
7. Save / Absorb to the determined location
|
||||||
|
|
||||||
|
|||||||
@@ -203,17 +203,17 @@ Synthesize both analyses, generate **Step-by-step Implementation Plan**:
|
|||||||
2. Save plan to `.claude/plan/<feature-name>.md` (extract feature name from requirement, e.g., `user-auth`, `payment-module`)
|
2. Save plan to `.claude/plan/<feature-name>.md` (extract feature name from requirement, e.g., `user-auth`, `payment-module`)
|
||||||
3. Output prompt in **bold text** (MUST use actual saved file path):
|
3. Output prompt in **bold text** (MUST use actual saved file path):
|
||||||
|
|
||||||
---
|
---
|
||||||
**Plan generated and saved to `.claude/plan/actual-feature-name.md`**
|
**Plan generated and saved to `.claude/plan/actual-feature-name.md`**
|
||||||
|
|
||||||
**Please review the plan above. You can:**
|
**Please review the plan above. You can:**
|
||||||
- **Modify plan**: Tell me what needs adjustment, I'll update the plan
|
- **Modify plan**: Tell me what needs adjustment, I'll update the plan
|
||||||
- **Execute plan**: Copy the following command to a new session
|
- **Execute plan**: Copy the following command to a new session
|
||||||
|
|
||||||
```
|
```
|
||||||
/ccg:execute .claude/plan/actual-feature-name.md
|
/ccg:execute .claude/plan/actual-feature-name.md
|
||||||
```
|
```
|
||||||
---
|
---
|
||||||
|
|
||||||
**NOTE**: The `actual-feature-name.md` above MUST be replaced with the actual saved filename!
|
**NOTE**: The `actual-feature-name.md` above MUST be replaced with the actual saved filename!
|
||||||
|
|
||||||
|
|||||||
@@ -50,9 +50,7 @@ const writeModeSkip = new Set([
|
|||||||
path.normalize('tests/scripts/check-unicode-safety.test.js'),
|
path.normalize('tests/scripts/check-unicode-safety.test.js'),
|
||||||
]);
|
]);
|
||||||
|
|
||||||
const dangerousInvisibleRe =
|
const emojiRe = /(?:\p{Extended_Pictographic}|\p{Regional_Indicator})/gu;
|
||||||
/[\u200B-\u200D\u2060\uFEFF\u202A-\u202E\u2066-\u2069\uFE00-\uFE0F\u{E0100}-\u{E01EF}]/gu;
|
|
||||||
const emojiRe = /[\p{Extended_Pictographic}\p{Regional_Indicator}]/gu;
|
|
||||||
const allowedSymbolCodePoints = new Set([
|
const allowedSymbolCodePoints = new Set([
|
||||||
0x00A9,
|
0x00A9,
|
||||||
0x00AE,
|
0x00AE,
|
||||||
@@ -106,9 +104,31 @@ function isAllowedEmojiLikeSymbol(char) {
|
|||||||
return allowedSymbolCodePoints.has(char.codePointAt(0));
|
return allowedSymbolCodePoints.has(char.codePointAt(0));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function isDangerousInvisibleCodePoint(codePoint) {
|
||||||
|
return (
|
||||||
|
(codePoint >= 0x200B && codePoint <= 0x200D) ||
|
||||||
|
codePoint === 0x2060 ||
|
||||||
|
codePoint === 0xFEFF ||
|
||||||
|
(codePoint >= 0x202A && codePoint <= 0x202E) ||
|
||||||
|
(codePoint >= 0x2066 && codePoint <= 0x2069) ||
|
||||||
|
(codePoint >= 0xFE00 && codePoint <= 0xFE0F) ||
|
||||||
|
(codePoint >= 0xE0100 && codePoint <= 0xE01EF)
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function stripDangerousInvisibleChars(text) {
|
||||||
|
let next = '';
|
||||||
|
for (const char of text) {
|
||||||
|
if (!isDangerousInvisibleCodePoint(char.codePointAt(0))) {
|
||||||
|
next += char;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return next;
|
||||||
|
}
|
||||||
|
|
||||||
function sanitizeText(text) {
|
function sanitizeText(text) {
|
||||||
let next = text;
|
let next = text;
|
||||||
next = next.replace(dangerousInvisibleRe, '');
|
next = stripDangerousInvisibleChars(next);
|
||||||
|
|
||||||
for (const [pattern, replacement] of targetedReplacements) {
|
for (const [pattern, replacement] of targetedReplacements) {
|
||||||
next = next.replace(pattern, replacement);
|
next = next.replace(pattern, replacement);
|
||||||
@@ -146,6 +166,28 @@ function collectMatches(text, regex, kind) {
|
|||||||
return matches;
|
return matches;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function collectDangerousInvisibleMatches(text) {
|
||||||
|
const matches = [];
|
||||||
|
let index = 0;
|
||||||
|
|
||||||
|
for (const char of text) {
|
||||||
|
const codePoint = char.codePointAt(0);
|
||||||
|
if (isDangerousInvisibleCodePoint(codePoint)) {
|
||||||
|
const { line, column } = lineAndColumn(text, index);
|
||||||
|
matches.push({
|
||||||
|
kind: 'dangerous-invisible',
|
||||||
|
char,
|
||||||
|
codePoint: `U+${codePoint.toString(16).toUpperCase()}`,
|
||||||
|
line,
|
||||||
|
column,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
index += char.length;
|
||||||
|
}
|
||||||
|
|
||||||
|
return matches;
|
||||||
|
}
|
||||||
|
|
||||||
const changedFiles = [];
|
const changedFiles = [];
|
||||||
const violations = [];
|
const violations = [];
|
||||||
|
|
||||||
@@ -172,7 +214,7 @@ for (const filePath of listFiles(repoRoot)) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const fileViolations = [
|
const fileViolations = [
|
||||||
...collectMatches(text, dangerousInvisibleRe, 'dangerous-invisible'),
|
...collectDangerousInvisibleMatches(text),
|
||||||
...collectMatches(text, emojiRe, 'emoji'),
|
...collectMatches(text, emojiRe, 'emoji'),
|
||||||
];
|
];
|
||||||
|
|
||||||
|
|||||||
@@ -116,8 +116,10 @@ if (
|
|||||||
fs.mkdirSync(codexDir, { recursive: true });
|
fs.mkdirSync(codexDir, { recursive: true });
|
||||||
fs.writeFileSync(configPath, config);
|
fs.writeFileSync(configPath, config);
|
||||||
|
|
||||||
const syncResult = runBash(syncScript, [], { HOME: homeDir, CODEX_HOME: codexDir });
|
const syncResult = runBash(syncScript, ['--update-mcp'], { HOME: homeDir, CODEX_HOME: codexDir });
|
||||||
assert.strictEqual(syncResult.status, 0, syncResult.stderr || syncResult.stdout);
|
assert.strictEqual(syncResult.status, 0, `${syncResult.stdout}\n${syncResult.stderr}`);
|
||||||
|
const syncedConfig = fs.readFileSync(configPath, 'utf8');
|
||||||
|
assert.match(syncedConfig, /^\[mcp_servers\.context7\]$/m);
|
||||||
|
|
||||||
const checkResult = runBash(checkScript, [], { HOME: homeDir, CODEX_HOME: codexDir });
|
const checkResult = runBash(checkScript, [], { HOME: homeDir, CODEX_HOME: codexDir });
|
||||||
assert.strictEqual(checkResult.status, 0, checkResult.stderr || checkResult.stdout);
|
assert.strictEqual(checkResult.status, 0, checkResult.stderr || checkResult.stdout);
|
||||||
|
|||||||
Reference in New Issue
Block a user