From 95d58fc2dd8ed15d0afcf3265704049152235116 Mon Sep 17 00:00:00 2001
From: hjkim0905 <eax9952@gmail.com>
Date: Mon, 25 May 2026 00:25:22 +0900
Subject: [PATCH] fix(skills): address nitpick comments on frontend-a11y

---
 skills/frontend-a11y/SKILL.md | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/skills/frontend-a11y/SKILL.md b/skills/frontend-a11y/SKILL.md
index 3176da4a..08763c1c 100644
--- a/skills/frontend-a11y/SKILL.md
+++ b/skills/frontend-a11y/SKILL.md
@@ -282,7 +282,15 @@ export function Dropdown({ options, onSelect }: { options: string[]; onSelect: (
   };
 
   return (
-    <div role="combobox" aria-expanded={isOpen} aria-haspopup="listbox" aria-controls={listId} tabIndex={0} onKeyDown={handleKeyDown} onClick={() => setIsOpen(prev => !prev)}>
+    <div
+      role="combobox"
+      aria-expanded={isOpen}
+      aria-haspopup="listbox"
+      aria-controls={listId}
+      tabIndex={0}
+      onKeyDown={handleKeyDown}
+      onClick={() => setIsOpen(prev => !prev)}
+    >
       <span>{options[activeIndex]}</span>
       {isOpen && (
         <ul id={listId} role="listbox">
@@ -427,7 +435,7 @@ Before submitting any interactive component for review:
 - [ ] No `onClick` on `<div>` or `<span>` without `role`, `tabIndex`, and `onKeyDown`
 - [ ] Icon-only buttons have `aria-label`
 - [ ] Decorative images use `alt=""` and `aria-hidden="true"`
-- [ ] Modals trap focus and restore it on close
+- [ ] Modals restore focus on close (for full focus trapping with Tab/Shift+Tab cycling, use a library like `focus-trap-react`)
 - [ ] Dynamic content updates use `aria-live`
 - [ ] `prefers-reduced-motion` is respected for animations