From 9b9f71c2e58b65b5d191188de71c80dfaa3571c1 Mon Sep 17 00:00:00 2001 From: AlexisLeDain Date: Wed, 8 Apr 2026 22:08:38 +0200 Subject: [PATCH] fix: address PR review findings for quarkus skills MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add missing objectMapper field to EventService example (quarkus-patterns) - Fix eventService.validate() → documentValidator.validate() API mismatch (quarkus-tdd) - Add DocumentValidator mock declaration in Camel route test (quarkus-tdd) - Update .opencode java-reviewer.txt to mention Quarkus alongside Spring Boot --- .opencode/prompts/agents/java-reviewer.txt | 2 +- skills/quarkus-patterns/SKILL.md | 1 + skills/quarkus-tdd/SKILL.md | 7 +++++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.opencode/prompts/agents/java-reviewer.txt b/.opencode/prompts/agents/java-reviewer.txt index 0e6dd7b8..55b29def 100644 --- a/.opencode/prompts/agents/java-reviewer.txt +++ b/.opencode/prompts/agents/java-reviewer.txt @@ -1,4 +1,4 @@ -You are a senior Java engineer ensuring high standards of idiomatic Java and Spring Boot best practices. +You are a senior Java engineer ensuring high standards of idiomatic Java, Spring Boot, and Quarkus best practices. When invoked: 1. Run `git diff -- '*.java'` to see recent Java file changes diff --git a/skills/quarkus-patterns/SKILL.md b/skills/quarkus-patterns/SKILL.md index d153a265..986c6ec6 100644 --- a/skills/quarkus-patterns/SKILL.md +++ b/skills/quarkus-patterns/SKILL.md @@ -156,6 +156,7 @@ public class ProcessingService { @RequiredArgsConstructor public class EventService { private final EventRepository eventRepository; + private final ObjectMapper objectMapper; public void createSuccessEvent(Object payload, String eventType) { Event event = new Event(); diff --git a/skills/quarkus-tdd/SKILL.md b/skills/quarkus-tdd/SKILL.md index c049ceda..6e942e03 100644 --- a/skills/quarkus-tdd/SKILL.md +++ b/skills/quarkus-tdd/SKILL.md @@ -265,6 +265,9 @@ class BusinessRulesRouteTest { @InjectMock EventService eventService; + @InjectMock + DocumentValidator documentValidator; + private BusinessRulesPayload testPayload; @BeforeEach @@ -371,8 +374,8 @@ class BusinessRulesRouteTest { }); camelContext.getRouteController().startRoute("document-processing"); - // Mock validator to throw exception - when(eventService.validate(any())).thenThrow(new ValidationException("Invalid document")); + // Mock validator bean to throw exception + when(documentValidator.validate(any())).thenThrow(new ValidationException("Invalid document")); // ACT producerTemplate.sendBody("direct:process-document", testPayload);