zsp/everything-claude-code
1
0
Fork 0
mirror of https://github.com/affaan-m/everything-claude-code.git synced 2026-06-13 03:33:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(observer): auto-scale max_turns by analysis batch size (#2062)

Browse Source 
* fix(observer): auto-scale max_turns by analysis batch size (#2035)

The hardcoded default of MAX_TURNS=20 is insufficient when
MAX_ANALYSIS_LINES=500 (also the default). Claude exhausts its turn
budget before it can write all discovered instinct files, producing:

  Error: Reached max turns (20)

Fix: when ECC_OBSERVER_MAX_TURNS is not explicitly set, compute
max_turns proportionally to the actual analysis batch size:
  max_turns = clamp(analysis_count / 10, 20, 100)

This gives:
  - 20–199 lines → 20 turns  (existing floor, unchanged)
  - 500 lines    → 50 turns  (resolves the reported failure)
  - 1000 lines   → 100 turns (cap)

Explicitly setting ECC_OBSERVER_MAX_TURNS still overrides the
auto-scaled value, preserving the existing escape hatch.

* test(observer): update max_turns test for auto-scaling; document validation

The max-turns budget test in tests/hooks/hooks.test.js still asserted the removed literal max_turns="${ECC_OBSERVER_MAX_TURNS:-20}", which would fail against the new auto-scaling logic. Assert the auto-scale formula and the 20/100 clamp bounds instead.

Also add the explanatory comment CodeRabbit requested above the max_turns sanitization block, clarifying it guards the explicit ECC_OBSERVER_MAX_TURNS override path.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
zucchini
2026-06-07 10:25:29 +05:00
committed by GitHub
parent d8a84b5f7b
commit a3d8d8ab92
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
skills/continuous-learning-v2/agents/observer-loop.sh
View File

@@ -205,9 +205,22 @@ PROMPT
fi
timeout_seconds="${ECC_OBSERVER_TIMEOUT_SECONDS:-120}"
max_turns="${ECC_OBSERVER_MAX_TURNS:-20}"
# Auto-scale max_turns proportional to analysis batch size when not explicitly set.
# The old hardcoded default of 20 is insufficient for the 500-line MAX_ANALYSIS_LINES
# default: Claude hits --max-turns before it can write all discovered instinct files.
# Formula: 1 turn per 10 analysis lines, floor 20, cap 100. (#2035)
if [ -n "${ECC_OBSERVER_MAX_TURNS:-}" ]; then
max_turns="${ECC_OBSERVER_MAX_TURNS}"
else
max_turns=$(( analysis_count / 10 ))
if [ "$max_turns" -lt 20 ]; then max_turns=20; fi
if [ "$max_turns" -gt 100 ]; then max_turns=100; fi
fi
exit_code=0
# Sanitize max_turns. The auto-scaled path above always yields a valid value >=20,
# but an explicit ECC_OBSERVER_MAX_TURNS override may be non-numeric, empty, or too
# small, so guard here and fall back to the safe default of 20.
case "$max_turns" in
''|*[!0-9]*)
max_turns=20