From b497135b958258e4c042d916edf025b139fd2c04 Mon Sep 17 00:00:00 2001
From: Affaan Mustafa <affaan@dcube.ai>
Date: Fri, 13 Feb 2026 04:05:12 -0800
Subject: [PATCH] fix: correct box() off-by-one width calculation in
 skill-create-output

The box() helper produced lines that were width+1 characters instead of
the requested width. Adjusted all three formulas (top border, middle
content, bottom border) by -1 each. Added 4 tests verifying box width
accuracy across instincts(), analysisResults(), and nextSteps() output.
---
 scripts/skill-create-output.js            |  6 +-
 tests/scripts/skill-create-output.test.js | 77 +++++++++++++++++++++++
 2 files changed, 80 insertions(+), 3 deletions(-)

diff --git a/scripts/skill-create-output.js b/scripts/skill-create-output.js
index 6e0bea69..0c7df3d0 100644
--- a/scripts/skill-create-output.js
+++ b/scripts/skill-create-output.js
@@ -38,10 +38,10 @@ const SPINNER = ['⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇',
 // Helper functions
 function box(title, content, width = 60) {
   const lines = content.split('\n');
-  const top = `${BOX.topLeft}${BOX.horizontal} ${chalk.bold(chalk.cyan(title))} ${BOX.horizontal.repeat(Math.max(0, width - title.length - 4))}${BOX.topRight}`;
-  const bottom = `${BOX.bottomLeft}${BOX.horizontal.repeat(width - 1)}${BOX.bottomRight}`;
+  const top = `${BOX.topLeft}${BOX.horizontal} ${chalk.bold(chalk.cyan(title))} ${BOX.horizontal.repeat(Math.max(0, width - title.length - 5))}${BOX.topRight}`;
+  const bottom = `${BOX.bottomLeft}${BOX.horizontal.repeat(width - 2)}${BOX.bottomRight}`;
   const middle = lines.map(line => {
-    const padding = width - 3 - stripAnsi(line).length;
+    const padding = width - 4 - stripAnsi(line).length;
     return `${BOX.vertical} ${line}${' '.repeat(Math.max(0, padding))} ${BOX.vertical}`;
   }).join('\n');
   return `${top}\n${middle}\n${bottom}`;
diff --git a/tests/scripts/skill-create-output.test.js b/tests/scripts/skill-create-output.test.js
index 77f92c56..703991bc 100644
--- a/tests/scripts/skill-create-output.test.js
+++ b/tests/scripts/skill-create-output.test.js
@@ -374,6 +374,83 @@ function runTests() {
       `Subtitle line should be 66 chars, got ${subtitleLine.length}`);
   })) passed++; else failed++;
 
+  // ── Round 35: box() width accuracy ──
+  console.log('\nbox() width accuracy (Round 35):');
+
+  if (test('box lines in instincts() match the default box width of 60', () => {
+    const output = new SkillCreateOutput('repo');
+    const logs = captureLog(() => output.instincts([
+      { name: 'test-instinct', confidence: 0.85 },
+    ]));
+    const combined = logs.join('\n');
+    const boxLines = combined.split('\n').filter(l => {
+      const s = stripAnsi(l).trim();
+      return s.startsWith('\u256D') || s.startsWith('\u2502') || s.startsWith('\u2570');
+    });
+    assert.ok(boxLines.length >= 3, 'Should have at least 3 box lines');
+    // The box() default width is 60 — each line should be exactly 60 chars
+    boxLines.forEach((l, i) => {
+      const w = stripAnsi(l).length;
+      assert.strictEqual(w, 60,
+        `Box line ${i} should be 60 chars wide, got ${w}`);
+    });
+  })) passed++; else failed++;
+
+  if (test('box lines with custom width match the requested width', () => {
+    const output = new SkillCreateOutput('repo', { width: 40 });
+    const logs = captureLog(() => output.instincts([
+      { name: 'short', confidence: 0.9 },
+    ]));
+    const combined = logs.join('\n');
+    const boxLines = combined.split('\n').filter(l => {
+      const s = stripAnsi(l).trim();
+      return s.startsWith('\u256D') || s.startsWith('\u2502') || s.startsWith('\u2570');
+    });
+    assert.ok(boxLines.length >= 3, 'Should have at least 3 box lines');
+    // instincts() calls box() with no explicit width, so it uses the default 60
+    // regardless of this.width — verify self-consistency at least
+    const firstWidth = stripAnsi(boxLines[0]).length;
+    boxLines.forEach((l, i) => {
+      const w = stripAnsi(l).length;
+      assert.strictEqual(w, firstWidth,
+        `Box line ${i} width ${w} should match first line ${firstWidth}`);
+    });
+  })) passed++; else failed++;
+
+  if (test('analysisResults box lines are all 60 chars wide', () => {
+    const output = new SkillCreateOutput('repo');
+    const logs = captureLog(() => output.analysisResults({
+      commits: 50, timeRange: 'Jan 2026', contributors: 2, files: 100,
+    }));
+    const combined = logs.join('\n');
+    const boxLines = combined.split('\n').filter(l => {
+      const s = stripAnsi(l).trim();
+      return s.startsWith('\u256D') || s.startsWith('\u2502') || s.startsWith('\u2570');
+    });
+    assert.ok(boxLines.length >= 3, 'Should have at least 3 box lines');
+    boxLines.forEach((l, i) => {
+      const w = stripAnsi(l).length;
+      assert.strictEqual(w, 60,
+        `Analysis box line ${i} should be 60 chars, got ${w}`);
+    });
+  })) passed++; else failed++;
+
+  if (test('nextSteps box lines are all 60 chars wide', () => {
+    const output = new SkillCreateOutput('repo');
+    const logs = captureLog(() => output.nextSteps());
+    const combined = logs.join('\n');
+    const boxLines = combined.split('\n').filter(l => {
+      const s = stripAnsi(l).trim();
+      return s.startsWith('\u256D') || s.startsWith('\u2502') || s.startsWith('\u2570');
+    });
+    assert.ok(boxLines.length >= 3, 'Should have at least 3 box lines');
+    boxLines.forEach((l, i) => {
+      const w = stripAnsi(l).length;
+      assert.strictEqual(w, 60,
+        `NextSteps box line ${i} should be 60 chars, got ${w}`);
+    });
+  })) passed++; else failed++;
+
   // Summary
   console.log(`\nResults: Passed: ${passed}, Failed: ${failed}`);
   process.exit(failed > 0 ? 1 : 0);