From b5c4d2beb9ff9405c5b392c06bdb32f0bcda6f6f Mon Sep 17 00:00:00 2001 From: Affaan Mustafa Date: Tue, 14 Apr 2026 20:43:22 -0700 Subject: [PATCH] fix: wire npm auth into release publish --- .github/workflows/release.yml | 2 ++ .github/workflows/reusable-release.yml | 5 +++++ tests/scripts/release-publish.test.js | 1 + 3 files changed, 8 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9dba67e0..b8252d63 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -68,6 +68,8 @@ jobs: - name: Publish npm package if: steps.npm_publish_state.outputs.already_published != 'true' + env: + NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} run: npm publish --access public --provenance - name: Generate release highlights diff --git a/.github/workflows/reusable-release.yml b/.github/workflows/reusable-release.yml index 8664dabb..4e4aaa48 100644 --- a/.github/workflows/reusable-release.yml +++ b/.github/workflows/reusable-release.yml @@ -12,6 +12,9 @@ on: required: false type: boolean default: true + secrets: + NPM_TOKEN: + required: false permissions: contents: write @@ -77,6 +80,8 @@ jobs: - name: Publish npm package if: steps.npm_publish_state.outputs.already_published != 'true' + env: + NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} run: npm publish --access public --provenance - name: Generate release highlights diff --git a/tests/scripts/release-publish.test.js b/tests/scripts/release-publish.test.js index eab473e6..b09c6979 100644 --- a/tests/scripts/release-publish.test.js +++ b/tests/scripts/release-publish.test.js @@ -48,6 +48,7 @@ for (const workflow of [ test(`${workflow} publishes new tag versions to npm`, () => { assert.match(content, /npm publish --access public --provenance/); + assert.match(content, /NODE_AUTH_TOKEN:\s*\$\{\{\s*secrets\.NPM_TOKEN\s*\}\}/); }); }