mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-06-14 20:21:23 +08:00
fix: add input guards to EventService to match TDD test expectations
Tests assert null-payload and blank-error-message guards but the implementation had none. Added Objects.requireNonNull for payload and blank check for errorMessage. Also added missing objectMapper field to locale copies.
This commit is contained in:
@@ -154,8 +154,10 @@ public class ProcessingService {
|
|||||||
@RequiredArgsConstructor
|
@RequiredArgsConstructor
|
||||||
public class EventService {
|
public class EventService {
|
||||||
private final EventRepository eventRepository;
|
private final EventRepository eventRepository;
|
||||||
|
private final ObjectMapper objectMapper;
|
||||||
|
|
||||||
public void createSuccessEvent(Object payload, String eventType) {
|
public void createSuccessEvent(Object payload, String eventType) {
|
||||||
|
Objects.requireNonNull(payload, "Payload cannot be null");
|
||||||
Event event = new Event();
|
Event event = new Event();
|
||||||
event.setType(eventType);
|
event.setType(eventType);
|
||||||
event.setStatus(EventStatus.SUCCESS);
|
event.setStatus(EventStatus.SUCCESS);
|
||||||
@@ -167,6 +169,10 @@ public class EventService {
|
|||||||
}
|
}
|
||||||
|
|
||||||
public void createErrorEvent(Object payload, String eventType, String errorMessage) {
|
public void createErrorEvent(Object payload, String eventType, String errorMessage) {
|
||||||
|
Objects.requireNonNull(payload, "Payload cannot be null");
|
||||||
|
if (errorMessage == null || errorMessage.isBlank()) {
|
||||||
|
throw new IllegalArgumentException("Error message cannot be blank");
|
||||||
|
}
|
||||||
Event event = new Event();
|
Event event = new Event();
|
||||||
event.setType(eventType);
|
event.setType(eventType);
|
||||||
event.setStatus(EventStatus.ERROR);
|
event.setStatus(EventStatus.ERROR);
|
||||||
|
|||||||
@@ -154,8 +154,10 @@ public class ProcessingService {
|
|||||||
@RequiredArgsConstructor
|
@RequiredArgsConstructor
|
||||||
public class EventService {
|
public class EventService {
|
||||||
private final EventRepository eventRepository;
|
private final EventRepository eventRepository;
|
||||||
|
private final ObjectMapper objectMapper;
|
||||||
|
|
||||||
public void createSuccessEvent(Object payload, String eventType) {
|
public void createSuccessEvent(Object payload, String eventType) {
|
||||||
|
Objects.requireNonNull(payload, "Payload cannot be null");
|
||||||
Event event = new Event();
|
Event event = new Event();
|
||||||
event.setType(eventType);
|
event.setType(eventType);
|
||||||
event.setStatus(EventStatus.SUCCESS);
|
event.setStatus(EventStatus.SUCCESS);
|
||||||
@@ -167,6 +169,10 @@ public class EventService {
|
|||||||
}
|
}
|
||||||
|
|
||||||
public void createErrorEvent(Object payload, String eventType, String errorMessage) {
|
public void createErrorEvent(Object payload, String eventType, String errorMessage) {
|
||||||
|
Objects.requireNonNull(payload, "Payload cannot be null");
|
||||||
|
if (errorMessage == null || errorMessage.isBlank()) {
|
||||||
|
throw new IllegalArgumentException("Error message cannot be blank");
|
||||||
|
}
|
||||||
Event event = new Event();
|
Event event = new Event();
|
||||||
event.setType(eventType);
|
event.setType(eventType);
|
||||||
event.setStatus(EventStatus.ERROR);
|
event.setStatus(EventStatus.ERROR);
|
||||||
|
|||||||
@@ -154,8 +154,10 @@ public class ProcessingService {
|
|||||||
@RequiredArgsConstructor
|
@RequiredArgsConstructor
|
||||||
public class EventService {
|
public class EventService {
|
||||||
private final EventRepository eventRepository;
|
private final EventRepository eventRepository;
|
||||||
|
private final ObjectMapper objectMapper;
|
||||||
|
|
||||||
public void createSuccessEvent(Object payload, String eventType) {
|
public void createSuccessEvent(Object payload, String eventType) {
|
||||||
|
Objects.requireNonNull(payload, "Payload cannot be null");
|
||||||
Event event = new Event();
|
Event event = new Event();
|
||||||
event.setType(eventType);
|
event.setType(eventType);
|
||||||
event.setStatus(EventStatus.SUCCESS);
|
event.setStatus(EventStatus.SUCCESS);
|
||||||
@@ -167,6 +169,10 @@ public class EventService {
|
|||||||
}
|
}
|
||||||
|
|
||||||
public void createErrorEvent(Object payload, String eventType, String errorMessage) {
|
public void createErrorEvent(Object payload, String eventType, String errorMessage) {
|
||||||
|
Objects.requireNonNull(payload, "Payload cannot be null");
|
||||||
|
if (errorMessage == null || errorMessage.isBlank()) {
|
||||||
|
throw new IllegalArgumentException("Error message cannot be blank");
|
||||||
|
}
|
||||||
Event event = new Event();
|
Event event = new Event();
|
||||||
event.setType(eventType);
|
event.setType(eventType);
|
||||||
event.setStatus(EventStatus.ERROR);
|
event.setStatus(EventStatus.ERROR);
|
||||||
|
|||||||
@@ -159,6 +159,7 @@ public class EventService {
|
|||||||
private final ObjectMapper objectMapper;
|
private final ObjectMapper objectMapper;
|
||||||
|
|
||||||
public void createSuccessEvent(Object payload, String eventType) {
|
public void createSuccessEvent(Object payload, String eventType) {
|
||||||
|
Objects.requireNonNull(payload, "Payload cannot be null");
|
||||||
Event event = new Event();
|
Event event = new Event();
|
||||||
event.setType(eventType);
|
event.setType(eventType);
|
||||||
event.setStatus(EventStatus.SUCCESS);
|
event.setStatus(EventStatus.SUCCESS);
|
||||||
@@ -170,6 +171,10 @@ public class EventService {
|
|||||||
}
|
}
|
||||||
|
|
||||||
public void createErrorEvent(Object payload, String eventType, String errorMessage) {
|
public void createErrorEvent(Object payload, String eventType, String errorMessage) {
|
||||||
|
Objects.requireNonNull(payload, "Payload cannot be null");
|
||||||
|
if (errorMessage == null || errorMessage.isBlank()) {
|
||||||
|
throw new IllegalArgumentException("Error message cannot be blank");
|
||||||
|
}
|
||||||
Event event = new Event();
|
Event event = new Event();
|
||||||
event.setType(eventType);
|
event.setType(eventType);
|
||||||
event.setStatus(EventStatus.ERROR);
|
event.setStatus(EventStatus.ERROR);
|
||||||
|
|||||||
Reference in New Issue
Block a user