zsp/everything-claude-code
1
0
Fork 0
mirror of https://github.com/affaan-m/everything-claude-code.git synced 2026-04-05 08:43:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: add 3 tests for TOCTOU catch paths and NaN date sort fallback (round 84)

Browse Source 
- getSessionById returns null for broken symlink (session-manager.js:307-310)
- findFiles skips broken symlinks matching the pattern (utils.js:170-173)
- listAliases sorts entries with invalid/missing dates via getTime() || 0 fallback
This commit is contained in:
Affaan Mustafa
2026-02-13 11:35:22 -08:00
parent 15717d6d04
commit cedcf9a701
3 changed files with 118 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/lib/session-manager.test.js
View File

@@ -1349,6 +1349,42 @@ src/main.ts
}
})) passed++; else failed++;
// ── Round 84: getSessionById TOCTOU — statSync catch returns null for broken symlink ──
console.log('\nRound 84: getSessionById (broken symlink — statSync catch):');
if (test('getSessionById returns null when matching session is a broken symlink', () => {
// getSessionById at line 307-310: statSync throws for broken symlinks,
// the catch returns null (file deleted between readdir and stat).
const isoHome = path.join(os.tmpdir(), `ecc-r84-getbyid-toctou-${Date.now()}`);
const sessionsDir = path.join(isoHome, '.claude', 'sessions');
fs.mkdirSync(sessionsDir, { recursive: true });
// Create a broken symlink that matches a session ID pattern
const brokenFile = '2026-02-11-deadbeef-session.tmp';
fs.symlinkSync('/nonexistent/target/that/does/not/exist', path.join(sessionsDir, brokenFile));
const origHome = process.env.HOME;
const origUserProfile = process.env.USERPROFILE;
try {
process.env.HOME = isoHome;
process.env.USERPROFILE = isoHome;
delete require.cache[require.resolve('../../scripts/lib/session-manager')];
delete require.cache[require.resolve('../../scripts/lib/utils')];
const freshSM = require('../../scripts/lib/session-manager');
// Search by the short ID "deadbeef" — should match the broken symlink
const result = freshSM.getSessionById('deadbeef');
assert.strictEqual(result, null,
'Should return null when matching session file is a broken symlink');
} finally {
process.env.HOME = origHome;
process.env.USERPROFILE = origUserProfile;
delete require.cache[require.resolve('../../scripts/lib/session-manager')];
delete require.cache[require.resolve('../../scripts/lib/utils')];
fs.rmSync(isoHome, { recursive: true, force: true });
}
})) passed++; else failed++;
// Summary
console.log(`\nResults: Passed: ${passed}, Failed: ${failed}`);
process.exit(failed > 0 ? 1 : 0);