mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-04-07 09:43:30 +08:00
fix(installer): reject invalid claude settings roots
This commit is contained in:
@@ -49,6 +49,9 @@ function mergeHooksIntoSettings(plan) {
|
|||||||
if (fs.existsSync(settingsPath)) {
|
if (fs.existsSync(settingsPath)) {
|
||||||
try {
|
try {
|
||||||
settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
|
settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
|
||||||
|
if (!settings || typeof settings !== 'object' || Array.isArray(settings)) {
|
||||||
|
throw new Error('root value must be a JSON object');
|
||||||
|
}
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
throw new Error(`Failed to parse existing settings at ${settingsPath}: ${error.message}`);
|
throw new Error(`Failed to parse existing settings at ${settingsPath}: ${error.message}`);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -441,6 +441,27 @@ function runTests() {
|
|||||||
}
|
}
|
||||||
})) passed++; else failed++;
|
})) passed++; else failed++;
|
||||||
|
|
||||||
|
if (test('fails when existing settings.json root is not an object', () => {
|
||||||
|
const homeDir = createTempDir('install-apply-home-');
|
||||||
|
const projectDir = createTempDir('install-apply-project-');
|
||||||
|
|
||||||
|
try {
|
||||||
|
const claudeRoot = path.join(homeDir, '.claude');
|
||||||
|
fs.mkdirSync(claudeRoot, { recursive: true });
|
||||||
|
const settingsPath = path.join(claudeRoot, 'settings.json');
|
||||||
|
fs.writeFileSync(settingsPath, '[]\n');
|
||||||
|
|
||||||
|
const result = run(['--profile', 'core'], { cwd: projectDir, homeDir });
|
||||||
|
assert.strictEqual(result.code, 1);
|
||||||
|
assert.ok(result.stderr.includes('Failed to parse existing settings at'));
|
||||||
|
assert.ok(result.stderr.includes('root value must be a JSON object'));
|
||||||
|
assert.strictEqual(fs.readFileSync(settingsPath, 'utf8'), '[]\n');
|
||||||
|
} finally {
|
||||||
|
cleanup(homeDir);
|
||||||
|
cleanup(projectDir);
|
||||||
|
}
|
||||||
|
})) passed++; else failed++;
|
||||||
|
|
||||||
if (test('installs from ecc-install.json and persists component selections', () => {
|
if (test('installs from ecc-install.json and persists component selections', () => {
|
||||||
const homeDir = createTempDir('install-apply-home-');
|
const homeDir = createTempDir('install-apply-home-');
|
||||||
const projectDir = createTempDir('install-apply-project-');
|
const projectDir = createTempDir('install-apply-project-');
|
||||||
|
|||||||
Reference in New Issue
Block a user