fix: address review feedback from PR #929

- Add missing code-review.md and development-workflow.md to zh/README.md directory listing
- Add mkdir -p command before copy in manual install instructions
- Fix TypeScript test command path in SKILL-DEVELOPMENT-GUIDE.md
- Add Anti-Patterns section to SKILL.md template
- Add Template category to Skill Categories table in CONTRIBUTING.md
- Add Pre-Review Requirements section to code-review.md (both en and zh)
- Add Pre-Review Checks step to development-workflow.md (both en and zh)
- Add trailing newlines to all files that were missing them
This commit is contained in:
xingzihai
2026-03-26 04:37:08 +00:00
parent c146fae2ce
commit da74f85c10
15 changed files with 57 additions and 18 deletions

View File

@@ -90,6 +90,10 @@ Main patterns and guidelines.
// Practical, tested examples
\`\`\`
## Anti-Patterns
Show what NOT to do with concrete examples.
## Best Practices
- Actionable guidelines
@@ -602,14 +606,14 @@ description: Quick reference for [API/Library].
Test all code examples:
```bash
# For TypeScript
npx tsc --noEmit examples/*.ts
# For TypeScript (run from inside the skill directory or specify the path)
npx tsc --noEmit skills/your-skill-name/examples/*.ts
# For Python
python -m py_compile examples/*.py
python -m py_compile skills/your-skill-name/examples/*.py
# For Go
go build ./examples/...
go build ./skills/your-skill-name/examples/...
```
---
@@ -903,4 +907,4 @@ npm run test:e2e
---
**Remember**: A good skill is focused, actionable, and immediately useful. Write skills you'd want to use yourself.
**Remember**: A good skill is focused, actionable, and immediately useful. Write skills you'd want to use yourself.