mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-03-30 13:43:26 +08:00
fix: address review feedback from PR #929
- Add missing code-review.md and development-workflow.md to zh/README.md directory listing - Add mkdir -p command before copy in manual install instructions - Fix TypeScript test command path in SKILL-DEVELOPMENT-GUIDE.md - Add Anti-Patterns section to SKILL.md template - Add Template category to Skill Categories table in CONTRIBUTING.md - Add Pre-Review Requirements section to code-review.md (both en and zh) - Add Pre-Review Checks step to development-workflow.md (both en and zh) - Add trailing newlines to all files that were missing them
This commit is contained in:
@@ -14,6 +14,14 @@ Code review ensures quality, security, and maintainability before code is merged
|
||||
- When architectural changes are made
|
||||
- Before merging pull requests
|
||||
|
||||
**Pre-Review Requirements:**
|
||||
|
||||
Before requesting review, ensure:
|
||||
|
||||
- All automated checks (CI/CD) are passing
|
||||
- Merge conflicts are resolved
|
||||
- Branch is up to date with target branch
|
||||
|
||||
## Review Checklist
|
||||
|
||||
Before marking code complete:
|
||||
@@ -113,4 +121,4 @@ This rule works with:
|
||||
- [testing.md](testing.md) - Test coverage requirements
|
||||
- [security.md](security.md) - Security checklist
|
||||
- [git-workflow.md](git-workflow.md) - Commit standards
|
||||
- [agents.md](agents.md) - Agent delegation
|
||||
- [agents.md](agents.md) - Agent delegation
|
||||
|
||||
@@ -36,3 +36,9 @@ The Feature Implementation Workflow describes the development pipeline: research
|
||||
- Detailed commit messages
|
||||
- Follow conventional commits format
|
||||
- See [git-workflow.md](./git-workflow.md) for commit message format and PR process
|
||||
|
||||
5. **Pre-Review Checks**
|
||||
- Verify all automated checks (CI/CD) are passing
|
||||
- Resolve any merge conflicts
|
||||
- Ensure branch is up to date with target branch
|
||||
- Only request review after these checks pass
|
||||
|
||||
Reference in New Issue
Block a user