zsp/everything-claude-code
1
0
Fork 0
mirror of https://github.com/affaan-m/everything-claude-code.git synced 2026-04-07 17:53:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: harden windows observer prompt handling

Browse Source
This commit is contained in:
Affaan Mustafa
2026-04-06 14:05:38 -07:00
parent 7dfdbe0b17
commit df96abe74c
3 changed files with 28 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/hooks/hooks.test.js
View File

@@ -2433,6 +2433,9 @@ async function runTests() {
assert.ok(!observerLoopSource.includes('--max-turns 3'), 'observer-loop should not hardcode a 3-turn limit');
assert.ok(observerLoopSource.includes('ECC_SKIP_OBSERVE=1'), 'observer-loop should suppress observe.sh for automated sessions');
assert.ok(observerLoopSource.includes('ECC_HOOK_PROFILE=minimal'), 'observer-loop should run automated analysis with the minimal hook profile');
assert.ok(observerLoopSource.includes('prompt_content="$(cat "$prompt_file" 2>/dev/null || true)"'), 'observer-loop should read prompt_file into memory before claude is spawned');
assert.ok(observerLoopSource.includes('-p "$prompt_content"'), 'observer-loop should pass in-memory prompt content to claude');
assert.ok(!observerLoopSource.includes('-p "$(cat "$prompt_file")"'), 'observer-loop should not re-read prompt_file at invocation time');
})
)
passed++;

10
tests/hooks/observer-memory.test.js
View File

@@ -164,7 +164,8 @@ test('default max analysis lines is 500', () => {
test('analysis temp file is created and cleaned up', () => {
const content = fs.readFileSync(observerLoopPath, 'utf8');
assert.ok(content.includes('ecc-observer-analysis'), 'Should create a temp analysis file');
assert.ok(content.includes('rm -f "$prompt_file" "$analysis_file"'), 'Should clean up both prompt and analysis temp files');
assert.ok(content.includes('rm -f "$prompt_file"'), 'Should clean up the prompt temp file after loading it');
assert.ok(content.includes('rm -f "$analysis_file"'), 'Should clean up the analysis temp file');
});
test('observer-loop uses project-local temp directory for analysis artifacts', () => {
@@ -174,6 +175,13 @@ test('observer-loop uses project-local temp directory for analysis artifacts', (
assert.ok(content.includes('mktemp "${observer_tmp_dir}/ecc-observer-prompt.'), 'Prompt temp file should use the project temp dir');
});
test('observer-loop loads prompt content before invoking claude', () => {
const content = fs.readFileSync(observerLoopPath, 'utf8');
assert.ok(content.includes('prompt_content="$(cat "$prompt_file" 2>/dev/null || true)"'), 'Prompt should be read into memory before the claude invocation');
assert.ok(content.includes('-p "$prompt_content"'), 'Claude should receive the in-memory prompt content');
assert.ok(!content.includes('-p "$(cat "$prompt_file")"'), 'Claude should not depend on re-reading the prompt file during invocation');
});
test('observer-loop prompt requires direct instinct writes without asking permission', () => {
const content = fs.readFileSync(observerLoopPath, 'utf8');
const heredocStart = content.indexOf('cat > "$prompt_file" <<PROMPT');