zsp/everything-claude-code
1
0
Fork 0
mirror of https://github.com/affaan-m/everything-claude-code.git synced 2026-04-11 03:43:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: harden CI validators, shell scripts, and expand test suite

Browse Source 
- Add try-catch around readFileSync in validate-agents, validate-commands,
  validate-skills to handle TOCTOU races and file read errors
- Add validate-hooks.js and all test suites to package.json test script
  (was only running 4/5 validators and 0/4 test files)
- Fix shell variable injection in observe.sh: use os.environ instead of
  interpolating $timestamp/$OBSERVATIONS_FILE into Python string literals
- Fix $? always being 0 in start-observer.sh: capture exit code before
  conditional since `if !` inverts the status
- Add OLD_VERSION validation in release.sh and use pipe delimiter in sed
  to avoid issues with slash-containing values
- Add jq dependency check in evaluate-session.sh before parsing config
- Sync .cursor/ copies of all modified shell scripts
This commit is contained in:
Affaan Mustafa
2026-02-12 14:11:33 -08:00
parent d048428643
commit f3a4b33d41
11 changed files with 70 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
.cursor/skills/continuous-learning-v2/agents/start-observer.sh
View File

@@ -88,10 +88,12 @@ case "${1:-start}" in
# Use Claude Code with Haiku to analyze observations # Use Claude Code with Haiku to analyze observations
# This spawns a quick analysis session # This spawns a quick analysis session
if command -v claude &> /dev/null; then if command -v claude &> /dev/null; then
if ! claude --model haiku --max-turns 3 --print \ exit_code=0
claude --model haiku --max-turns 3 --print \
"Read $OBSERVATIONS_FILE and identify patterns. If you find 3+ occurrences of the same pattern, create an instinct file in $CONFIG_DIR/instincts/personal/ following the format in the observer agent spec. Be conservative - only create instincts for clear patterns." \ "Read $OBSERVATIONS_FILE and identify patterns. If you find 3+ occurrences of the same pattern, create an instinct file in $CONFIG_DIR/instincts/personal/ following the format in the observer agent spec. Be conservative - only create instincts for clear patterns." \
>> "$LOG_FILE" 2>&1; then >> "$LOG_FILE" 2>&1 || exit_code=$?
echo "[$(date)] Claude analysis failed (exit $?)" >> "$LOG_FILE" if [ "$exit_code" -ne 0 ]; then
echo "[$(date)] Claude analysis failed (exit $exit_code)" >> "$LOG_FILE"
fi fi
else else
echo "[$(date)] claude CLI not found, skipping analysis" >> "$LOG_FILE" echo "[$(date)] claude CLI not found, skipping analysis" >> "$LOG_FILE"

17
.cursor/skills/continuous-learning-v2/hooks/observe.sh
View File

@@ -103,10 +103,10 @@ PARSED_OK=$(echo "$PARSED" | python3 -c "import json,sys; print(json.load(sys.st
if [ "$PARSED_OK" != "True" ]; then if [ "$PARSED_OK" != "True" ]; then
# Fallback: log raw input for debugging # Fallback: log raw input for debugging
timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ") timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
echo "$INPUT_JSON" | python3 -c " TIMESTAMP="$timestamp" echo "$INPUT_JSON" | python3 -c "
import json, sys import json, sys, os
raw = sys.stdin.read()[:2000] raw = sys.stdin.read()[:2000]
print(json.dumps({'timestamp': '$timestamp', 'event': 'parse_error', 'raw': raw})) print(json.dumps({'timestamp': os.environ['TIMESTAMP'], 'event': 'parse_error', 'raw': raw}))
" >> "$OBSERVATIONS_FILE" " >> "$OBSERVATIONS_FILE"
exit 0 exit 0
fi fi
@@ -124,12 +124,12 @@ fi
# Build and write observation # Build and write observation
timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ") timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
echo "$PARSED" | python3 -c " TIMESTAMP="$timestamp" echo "$PARSED" | python3 -c "
import json, sys import json, sys, os
parsed = json.load(sys.stdin) parsed = json.load(sys.stdin)
observation = { observation = {
'timestamp': '$timestamp', 'timestamp': os.environ['TIMESTAMP'],
'event': parsed['event'], 'event': parsed['event'],
'tool': parsed['tool'], 'tool': parsed['tool'],
'session': parsed['session'] 'session': parsed['session']
@@ -140,9 +140,8 @@ if parsed['input']:
if parsed['output']: if parsed['output']:
observation['output'] = parsed['output'] observation['output'] = parsed['output']
with open('$OBSERVATIONS_FILE', 'a') as f: print(json.dumps(observation))
f.write(json.dumps(observation) + '\n') " >> "$OBSERVATIONS_FILE"
"
# Signal observer if running # Signal observer if running
OBSERVER_PID_FILE="${CONFIG_DIR}/.observer.pid" OBSERVER_PID_FILE="${CONFIG_DIR}/.observer.pid"

8
.cursor/skills/continuous-learning/evaluate-session.sh
View File

@@ -32,8 +32,12 @@ MIN_SESSION_LENGTH=10
# Load config if exists # Load config if exists
if [ -f "$CONFIG_FILE" ]; then if [ -f "$CONFIG_FILE" ]; then
MIN_SESSION_LENGTH=$(jq -r '.min_session_length // 10' "$CONFIG_FILE") if ! command -v jq &>/dev/null; then
LEARNED_SKILLS_PATH=$(jq -r '.learned_skills_path // "~/.claude/skills/learned/"' "$CONFIG_FILE" | sed "s|~|$HOME|") echo "[ContinuousLearning] jq is required to parse config.json but not installed, using defaults" >&2
else
MIN_SESSION_LENGTH=$(jq -r '.min_session_length // 10' "$CONFIG_FILE")
LEARNED_SKILLS_PATH=$(jq -r '.learned_skills_path // "~/.claude/skills/learned/"' "$CONFIG_FILE" | sed "s|~|$HOME|")
fi
fi fi
# Ensure learned skills directory exists # Ensure learned skills directory exists

2
package.json
View File

@@ -75,7 +75,7 @@
"scripts": { "scripts": {
"postinstall": "echo '\\n ecc-universal installed!\\n Run: npx ecc-install typescript\\n Docs: https://github.com/affaan-m/everything-claude-code\\n'", "postinstall": "echo '\\n ecc-universal installed!\\n Run: npx ecc-install typescript\\n Docs: https://github.com/affaan-m/everything-claude-code\\n'",
"lint": "eslint . && markdownlint '**/*.md' --ignore node_modules", "lint": "eslint . && markdownlint '**/*.md' --ignore node_modules",
"test": "node scripts/ci/validate-agents.js && node scripts/ci/validate-commands.js && node scripts/ci/validate-rules.js && node scripts/ci/validate-skills.js" "test": "node scripts/ci/validate-agents.js && node scripts/ci/validate-commands.js && node scripts/ci/validate-rules.js && node scripts/ci/validate-skills.js && node scripts/ci/validate-hooks.js && node tests/lib/utils.test.js && node tests/lib/package-manager.test.js && node tests/hooks/hooks.test.js && node tests/integration/hooks.test.js"
}, },
"devDependencies": { "devDependencies": {
"@eslint/js": "^9.39.2", "@eslint/js": "^9.39.2",

9
scripts/ci/validate-agents.js
View File

@@ -40,7 +40,14 @@ function validateAgents() {
for (const file of files) { for (const file of files) {
const filePath = path.join(AGENTS_DIR, file); const filePath = path.join(AGENTS_DIR, file);
const content = fs.readFileSync(filePath, 'utf-8'); let content;
try {
content = fs.readFileSync(filePath, 'utf-8');
} catch (err) {
console.error(`ERROR: ${file} - ${err.message}`);
hasErrors = true;
continue;
}
const frontmatter = extractFrontmatter(content); const frontmatter = extractFrontmatter(content);
if (!frontmatter) { if (!frontmatter) {

9
scripts/ci/validate-commands.js
View File

@@ -19,7 +19,14 @@ function validateCommands() {
for (const file of files) { for (const file of files) {
const filePath = path.join(COMMANDS_DIR, file); const filePath = path.join(COMMANDS_DIR, file);
const content = fs.readFileSync(filePath, 'utf-8'); let content;
try {
content = fs.readFileSync(filePath, 'utf-8');
} catch (err) {
console.error(`ERROR: ${file} - ${err.message}`);
hasErrors = true;
continue;
}
// Validate the file is non-empty readable markdown // Validate the file is non-empty readable markdown
if (content.trim().length === 0) { if (content.trim().length === 0) {

9
scripts/ci/validate-skills.js
View File

@@ -27,7 +27,14 @@ function validateSkills() {
continue; continue;
} }
const content = fs.readFileSync(skillMd, 'utf-8'); let content;
try {
content = fs.readFileSync(skillMd, 'utf-8');
} catch (err) {
console.error(`ERROR: ${dir}/SKILL.md - ${err.message}`);
hasErrors = true;
continue;
}
if (content.trim().length === 0) { if (content.trim().length === 0) {
console.error(`ERROR: ${dir}/SKILL.md - Empty file`); console.error(`ERROR: ${dir}/SKILL.md - Empty file`);
hasErrors = true; hasErrors = true;

10
scripts/release.sh
View File

@@ -47,15 +47,19 @@ fi
# Read current version # Read current version
OLD_VERSION=$(grep -oE '"version": *"[^"]*"' "$PLUGIN_JSON" | grep -oE '[0-9]+\.[0-9]+\.[0-9]+') OLD_VERSION=$(grep -oE '"version": *"[^"]*"' "$PLUGIN_JSON" | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')
if [[ -z "$OLD_VERSION" ]]; then
echo "Error: Could not extract current version from $PLUGIN_JSON"
exit 1
fi
echo "Bumping version: $OLD_VERSION -> $VERSION" echo "Bumping version: $OLD_VERSION -> $VERSION"
# Update version in plugin.json (cross-platform sed) # Update version in plugin.json (cross-platform sed, pipe-delimiter avoids issues with slashes)
if [[ "$OSTYPE" == "darwin"* ]]; then if [[ "$OSTYPE" == "darwin"* ]]; then
# macOS # macOS
sed -i '' "s/\"version\": *\"[^\"]*\"/\"version\": \"$VERSION\"/" "$PLUGIN_JSON" sed -i '' "s|\"version\": *\"[^\"]*\"|\"version\": \"$VERSION\"|" "$PLUGIN_JSON"
else else
# Linux # Linux
sed -i "s/\"version\": *\"[^\"]*\"/\"version\": \"$VERSION\"/" "$PLUGIN_JSON" sed -i "s|\"version\": *\"[^\"]*\"|\"version\": \"$VERSION\"|" "$PLUGIN_JSON"
fi fi
# Stage, commit, tag, and push # Stage, commit, tag, and push

8
skills/continuous-learning-v2/agents/start-observer.sh
View File

@@ -88,10 +88,12 @@ case "${1:-start}" in
# Use Claude Code with Haiku to analyze observations # Use Claude Code with Haiku to analyze observations
# This spawns a quick analysis session # This spawns a quick analysis session
if command -v claude &> /dev/null; then if command -v claude &> /dev/null; then
if ! claude --model haiku --max-turns 3 --print \ exit_code=0
claude --model haiku --max-turns 3 --print \
"Read $OBSERVATIONS_FILE and identify patterns. If you find 3+ occurrences of the same pattern, create an instinct file in $CONFIG_DIR/instincts/personal/ following the format in the observer agent spec. Be conservative - only create instincts for clear patterns." \ "Read $OBSERVATIONS_FILE and identify patterns. If you find 3+ occurrences of the same pattern, create an instinct file in $CONFIG_DIR/instincts/personal/ following the format in the observer agent spec. Be conservative - only create instincts for clear patterns." \
>> "$LOG_FILE" 2>&1; then >> "$LOG_FILE" 2>&1 || exit_code=$?
echo "[$(date)] Claude analysis failed (exit $?)" >> "$LOG_FILE" if [ "$exit_code" -ne 0 ]; then
echo "[$(date)] Claude analysis failed (exit $exit_code)" >> "$LOG_FILE"
fi fi
else else
echo "[$(date)] claude CLI not found, skipping analysis" >> "$LOG_FILE" echo "[$(date)] claude CLI not found, skipping analysis" >> "$LOG_FILE"

17
skills/continuous-learning-v2/hooks/observe.sh
View File

@@ -103,10 +103,10 @@ PARSED_OK=$(echo "$PARSED" | python3 -c "import json,sys; print(json.load(sys.st
if [ "$PARSED_OK" != "True" ]; then if [ "$PARSED_OK" != "True" ]; then
# Fallback: log raw input for debugging # Fallback: log raw input for debugging
timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ") timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
echo "$INPUT_JSON" | python3 -c " TIMESTAMP="$timestamp" echo "$INPUT_JSON" | python3 -c "
import json, sys import json, sys, os
raw = sys.stdin.read()[:2000] raw = sys.stdin.read()[:2000]
print(json.dumps({'timestamp': '$timestamp', 'event': 'parse_error', 'raw': raw})) print(json.dumps({'timestamp': os.environ['TIMESTAMP'], 'event': 'parse_error', 'raw': raw}))
" >> "$OBSERVATIONS_FILE" " >> "$OBSERVATIONS_FILE"
exit 0 exit 0
fi fi
@@ -124,12 +124,12 @@ fi
# Build and write observation # Build and write observation
timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ") timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
echo "$PARSED" | python3 -c " TIMESTAMP="$timestamp" echo "$PARSED" | python3 -c "
import json, sys import json, sys, os
parsed = json.load(sys.stdin) parsed = json.load(sys.stdin)
observation = { observation = {
'timestamp': '$timestamp', 'timestamp': os.environ['TIMESTAMP'],
'event': parsed['event'], 'event': parsed['event'],
'tool': parsed['tool'], 'tool': parsed['tool'],
'session': parsed['session'] 'session': parsed['session']
@@ -140,9 +140,8 @@ if parsed['input']:
if parsed['output']: if parsed['output']:
observation['output'] = parsed['output'] observation['output'] = parsed['output']
with open('$OBSERVATIONS_FILE', 'a') as f: print(json.dumps(observation))
f.write(json.dumps(observation) + '\n') " >> "$OBSERVATIONS_FILE"
"
# Signal observer if running # Signal observer if running
OBSERVER_PID_FILE="${CONFIG_DIR}/.observer.pid" OBSERVER_PID_FILE="${CONFIG_DIR}/.observer.pid"

8
skills/continuous-learning/evaluate-session.sh
View File

@@ -32,8 +32,12 @@ MIN_SESSION_LENGTH=10
# Load config if exists # Load config if exists
if [ -f "$CONFIG_FILE" ]; then if [ -f "$CONFIG_FILE" ]; then
MIN_SESSION_LENGTH=$(jq -r '.min_session_length // 10' "$CONFIG_FILE") if ! command -v jq &>/dev/null; then
LEARNED_SKILLS_PATH=$(jq -r '.learned_skills_path // "~/.claude/skills/learned/"' "$CONFIG_FILE" | sed "s|~|$HOME|") echo "[ContinuousLearning] jq is required to parse config.json but not installed, using defaults" >&2
else
MIN_SESSION_LENGTH=$(jq -r '.min_session_length // 10' "$CONFIG_FILE")
LEARNED_SKILLS_PATH=$(jq -r '.learned_skills_path // "~/.claude/skills/learned/"' "$CONFIG_FILE" | sed "s|~|$HOME|")
fi
fi fi
# Ensure learned skills directory exists # Ensure learned skills directory exists