mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-04-09 10:53:34 +08:00
test: cover findFiles unreadable subdir, session-start default PM, setPreferredPM save failure
Round 71: Add 3 tests for untested code paths (815 → 818): - utils.js findFiles: recursive scan silently skips unreadable subdirectories (line 188 catch) - session-start.js: shows getSelectionPrompt when pm.source is 'default' (lines 69-72) - package-manager.js: setPreferredPackageManager wraps saveConfig errors (lines 250-254)
This commit is contained in:
@@ -1269,6 +1269,43 @@ function runTests() {
|
||||
}
|
||||
})) passed++; else failed++;
|
||||
|
||||
// ── Round 71: setPreferredPackageManager save failure wraps error ──
|
||||
console.log('\nRound 71: setPreferredPackageManager (save failure):');
|
||||
|
||||
if (test('setPreferredPackageManager throws wrapped error when save fails', () => {
|
||||
if (process.platform === 'win32' || process.getuid?.() === 0) {
|
||||
console.log(' (skipped — chmod ineffective on Windows/root)');
|
||||
return;
|
||||
}
|
||||
const isoHome = path.join(os.tmpdir(), `ecc-pm-r71-${Date.now()}`);
|
||||
const claudeDir = path.join(isoHome, '.claude');
|
||||
fs.mkdirSync(claudeDir, { recursive: true });
|
||||
|
||||
const savedHome = process.env.HOME;
|
||||
const savedProfile = process.env.USERPROFILE;
|
||||
try {
|
||||
process.env.HOME = isoHome;
|
||||
process.env.USERPROFILE = isoHome;
|
||||
delete require.cache[require.resolve('../../scripts/lib/package-manager')];
|
||||
delete require.cache[require.resolve('../../scripts/lib/utils')];
|
||||
const freshPm = require('../../scripts/lib/package-manager');
|
||||
|
||||
// Make .claude directory read-only — can't create new files (package-manager.json)
|
||||
fs.chmodSync(claudeDir, 0o555);
|
||||
|
||||
assert.throws(() => {
|
||||
freshPm.setPreferredPackageManager('npm');
|
||||
}, /Failed to save package manager preference/);
|
||||
} finally {
|
||||
try { fs.chmodSync(claudeDir, 0o755); } catch { /* best-effort */ }
|
||||
process.env.HOME = savedHome;
|
||||
process.env.USERPROFILE = savedProfile;
|
||||
delete require.cache[require.resolve('../../scripts/lib/package-manager')];
|
||||
delete require.cache[require.resolve('../../scripts/lib/utils')];
|
||||
fs.rmSync(isoHome, { recursive: true, force: true });
|
||||
}
|
||||
})) passed++; else failed++;
|
||||
|
||||
// Summary
|
||||
console.log('\n=== Test Results ===');
|
||||
console.log(`Passed: ${passed}`);
|
||||
|
||||
@@ -1062,6 +1062,40 @@ function runTests() {
|
||||
'All-invalid patterns should return same result as no patterns (no filtering)');
|
||||
})) passed++; else failed++;
|
||||
|
||||
// ── Round 71: findFiles recursive scan skips unreadable subdirectory ──
|
||||
console.log('\nRound 71: findFiles (unreadable subdirectory in recursive scan):');
|
||||
|
||||
if (test('findFiles recursive scan skips unreadable subdirectory silently', () => {
|
||||
if (process.platform === 'win32' || process.getuid?.() === 0) {
|
||||
console.log(' (skipped — chmod ineffective on Windows/root)');
|
||||
return;
|
||||
}
|
||||
const tmpDir = path.join(utils.getTempDir(), `ecc-findfiles-r71-${Date.now()}`);
|
||||
const readableSubdir = path.join(tmpDir, 'readable');
|
||||
const unreadableSubdir = path.join(tmpDir, 'unreadable');
|
||||
fs.mkdirSync(readableSubdir, { recursive: true });
|
||||
fs.mkdirSync(unreadableSubdir, { recursive: true });
|
||||
|
||||
// Create files in both subdirectories
|
||||
fs.writeFileSync(path.join(readableSubdir, 'found.txt'), 'data');
|
||||
fs.writeFileSync(path.join(unreadableSubdir, 'hidden.txt'), 'data');
|
||||
|
||||
// Make the subdirectory unreadable — readdirSync will throw EACCES
|
||||
fs.chmodSync(unreadableSubdir, 0o000);
|
||||
|
||||
try {
|
||||
const results = utils.findFiles(tmpDir, '*.txt', { recursive: true });
|
||||
// Should find the readable file but silently skip the unreadable dir
|
||||
assert.ok(results.length >= 1, 'Should find at least the readable file');
|
||||
const paths = results.map(r => r.path);
|
||||
assert.ok(paths.some(p => p.includes('found.txt')), 'Should find readable/found.txt');
|
||||
assert.ok(!paths.some(p => p.includes('hidden.txt')), 'Should not find unreadable/hidden.txt');
|
||||
} finally {
|
||||
fs.chmodSync(unreadableSubdir, 0o755);
|
||||
fs.rmSync(tmpDir, { recursive: true, force: true });
|
||||
}
|
||||
})) passed++; else failed++;
|
||||
|
||||
// Summary
|
||||
console.log('\n=== Test Results ===');
|
||||
console.log(`Passed: ${passed}`);
|
||||
|
||||
Reference in New Issue
Block a user