mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-04-06 17:23:28 +08:00
1.8 KiB
1.8 KiB
description, agent, subtask
| description | agent | subtask |
|---|---|---|
| Rust code review for ownership, safety, and idiomatic patterns | everything-claude-code:rust-reviewer | true |
Rust Review Command
Review Rust code for idiomatic patterns and best practices: $ARGUMENTS
Your Task
- Analyze Rust code for idioms and patterns
- Check ownership - borrowing, lifetimes, unnecessary clones
- Review error handling - proper
?propagation, no unwrap in production - Verify safety - unsafe usage, injection, secrets
Review Checklist
Safety (CRITICAL)
- No unchecked
unwrap()/expect()in production paths unsafeblocks have// SAFETY:comments- No SQL/command injection
- No hardcoded secrets
Ownership (HIGH)
- No unnecessary
.clone()to satisfy borrow checker &strpreferred overStringin function parameters&[T]preferred overVec<T>in function parameters- No excessive lifetime annotations where elision works
Error Handling (HIGH)
- Errors propagated with
?; use.context()inanyhow/eyreapplication code - No silenced errors (
let _ = result;) thiserrorfor library errors,anyhowfor applications
Concurrency (HIGH)
- No blocking in async context
- Bounded channels preferred
Mutexpoisoning handledSend/Syncbounds correct
Code Quality (MEDIUM)
- Functions under 50 lines
- No deep nesting (>4 levels)
- Exhaustive matching on business enums
- Clippy warnings addressed
Report Format
CRITICAL Issues
- [file:line] Issue description Suggestion: How to fix
HIGH Issues
- [file:line] Issue description Suggestion: How to fix
MEDIUM Issues
- [file:line] Issue description Suggestion: How to fix
TIP: Run cargo clippy -- -D warnings and cargo fmt --check for automated checks.