mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-03-30 21:53:28 +08:00
* feat(agents): add Rust language support — reviewer, build resolver, patterns, and testing
Add Rust-specific agents and skills following the established Go/Kotlin pattern:
- agents/rust-reviewer.md: ownership, lifetimes, unsafe audit, clippy, error handling
- agents/rust-build-resolver.md: cargo build errors, borrow checker, dependency resolution
- skills/rust-patterns/SKILL.md: idiomatic Rust patterns and best practices
- skills/rust-testing/SKILL.md: TDD, unit/integration/async/property-based testing
* fix(agents): correct Rust examples for accuracy and consistency
- unsafe fn: add inner unsafe {} block for Rust 2024 edition compliance
- edition: update from 2021 to 2024 as current default
- rstest: add missing fixture import
- mockall: add missing predicate::eq import
- concurrency: use sync_channel (bounded) and expect() over unwrap()
to align with rust-reviewer's HIGH-priority review checks
* fix(skills): correct compilation issues in Rust code examples
- collect: add .copied() for &str iterator into String
- tokio import: remove unused sleep, keep Duration
- async test: add missing Duration import
* fix(skills): move --no-fail-fast before test-binary args
--no-fail-fast is a Cargo option, not a test binary flag.
Placing it after -- forwards it to the test harness where it is
unrecognized.
* fix(agents): distinguish missing cargo-audit from real audit failures
Check if cargo-audit is installed before running it, so actual
vulnerability findings are not suppressed by the fallback message.
* fix: address automated review findings across all Rust files
- build-resolver: prefer scoped cargo update over full refresh
- testing: add Cargo.toml bench config with harness = false for criterion
- testing: condense TDD example to stay under 500-line limit
- patterns: use expect() over unwrap() on JoinHandle for consistency
- patterns: add explicit lifetime to unsafe FFI return reference
- reviewer: replace misleading "string interpolation" with concrete alternatives
* fix: align with CONTRIBUTING.md conventions
- skills: rename "When to Activate" to "When to Use" per template
- reviewer: add cargo check gate before starting review
* fix(agents): guard cargo-audit and cargo-deny with availability checks
Match the pattern used in rust-build-resolver to avoid command-not-found
errors when optional tools are not installed.
* fix: address second round of automated review findings
- testing: split TDD example into separate code blocks to avoid
duplicate fn definition in single block
- build-resolver/reviewer: use if/then/else instead of && ... ||
chaining for cargo-audit/deny to avoid masking real failures
- build-resolver: add MSRV caveat to edition upgrade guidance
* feat: add Rust slash commands for build, review, and test
Add commands/rust-build.md, commands/rust-review.md, and
commands/rust-test.md to provide consistent user entrypoints
matching the existing Go and Kotlin command patterns.
* fix(commands): improve rust-build accuracy and tone
- Restructure-first borrow fix example instead of clone-first
- Realistic cargo test output format (per-test lines, not per-file)
- Align "Parse Errors" step with actual resolver behavior
- Prefer restructuring over cloning in common errors table
* fix: address cubic-dev-ai review findings on commands
- Gate review on all automated checks, not just cargo check
- Use git diff HEAD~1 / git diff main...HEAD for PR file selection
- Fix #[must_use] guidance: Result is already must_use by type
- Remove error-masking fallback on cargo tree --duplicates
* fix: address remaining review findings across all bots
- Add rust-reviewer and rust-build-resolver to AGENTS.md registry
- Update agent count from 16 to 18
- Mark parse_config doctest as no_run (body is todo!())
- Add "How It Works" section to both Rust skills
- Replace cargo install with taiki-e/install-action in CI snippet
- Trim tarpaulin section to stay under 500-line limit
* fix(agents): align rust-reviewer invocation with command spec
- Use git diff HEAD~1 / main...HEAD instead of bare git diff
- Add cargo test as explicit step before review begins
* fix(skills): address cubic review on patterns and testing
- Remove Tokio-specific language from How It Works summary
- Add cargo-llvm-cov install note in coverage section
- Revert no_run on doctest examples (illustrative code, not compiled)
* fix(skills): use expect on thread join for consistency
Replace handle.join().unwrap() with .expect("worker thread panicked")
to match the .expect("mutex poisoned") pattern used above.
* fix(agents): gate review on all automated checks, not just cargo check
Consolidate check/clippy/fmt/test into a single gate step that
stops and reports if any fail, matching the command spec.
* fix(skills): replace unwrap with expect in channel example
Use .expect("receiver disconnected") on tx.send() for consistency
with the .expect() convention used in all other concurrency examples.
* fix: address final review round — OpenCode mirrors, counts, examples
- Add .opencode/commands/rust-{build,review,test}.md mirrors
- Add .opencode/prompts/agents/rust-{build-resolver,reviewer}.txt mirrors
- Fix AGENTS.md count to 20 (add missing kotlin agents to table)
- Fix review example: all checks pass (consistent with gate policy)
- Replace should_panic doctest with is_err() (consistent with best practices)
- Trim testing commands to stay at 500-line limit
* fix: address cubic and greptile review on OpenCode files and agents
- Fix crate::module import guidance (internal path, not Cargo.toml)
- Add cargo fmt --check to verification steps
- Fix TDD GREEN example to handle error path (validate(input)?)
- Scope .context() guidance to anyhow/eyre application code
- Update command count from 40 to 51
- Add tokio channel variants to unbounded channel warning
- Preserve JoinError context in spawned task panic message
* fix: stale command count, channel guidance, cargo tree fallback
- Fix stale command count in Project Structure section (40→51)
- Clarify unbounded channel rule: context-appropriate bounded alternatives
- Remove dead cargo tree fallback (exits 0 even with no duplicates)
- Sync OpenCode reviewer mirror with tokio channel coverage
5.7 KiB
5.7 KiB
name, description, tools, model
| name | description | tools | model | ||||||
|---|---|---|---|---|---|---|---|---|---|
| rust-build-resolver | Rust build, compilation, and dependency error resolution specialist. Fixes cargo build errors, borrow checker issues, and Cargo.toml problems with minimal changes. Use when Rust builds fail. |
|
sonnet |
Rust Build Error Resolver
You are an expert Rust build error resolution specialist. Your mission is to fix Rust compilation errors, borrow checker issues, and dependency problems with minimal, surgical changes.
Core Responsibilities
- Diagnose
cargo build/cargo checkerrors - Fix borrow checker and lifetime errors
- Resolve trait implementation mismatches
- Handle Cargo dependency and feature issues
- Fix
cargo clippywarnings
Diagnostic Commands
Run these in order:
cargo check 2>&1
cargo clippy -- -D warnings 2>&1
cargo fmt --check 2>&1
cargo tree --duplicates 2>&1
if command -v cargo-audit >/dev/null; then cargo audit; else echo "cargo-audit not installed"; fi
Resolution Workflow
1. cargo check -> Parse error message and error code
2. Read affected file -> Understand ownership and lifetime context
3. Apply minimal fix -> Only what's needed
4. cargo check -> Verify fix
5. cargo clippy -> Check for warnings
6. cargo test -> Ensure nothing broke
Common Fix Patterns
| Error | Cause | Fix |
|---|---|---|
cannot borrow as mutable |
Immutable borrow active | Restructure to end immutable borrow first, or use Cell/RefCell |
does not live long enough |
Value dropped while still borrowed | Extend lifetime scope, use owned type, or add lifetime annotation |
cannot move out of |
Moving from behind a reference | Use .clone(), .to_owned(), or restructure to take ownership |
mismatched types |
Wrong type or missing conversion | Add .into(), as, or explicit type conversion |
trait X is not implemented for Y |
Missing impl or derive | Add #[derive(Trait)] or implement trait manually |
unresolved import |
Missing dependency or wrong path | Add to Cargo.toml or fix use path |
unused variable / unused import |
Dead code | Remove or prefix with _ |
expected X, found Y |
Type mismatch in return/argument | Fix return type or add conversion |
cannot find macro |
Missing #[macro_use] or feature |
Add dependency feature or import macro |
multiple applicable items |
Ambiguous trait method | Use fully qualified syntax: <Type as Trait>::method() |
lifetime may not live long enough |
Lifetime bound too short | Add lifetime bound or use 'static where appropriate |
async fn is not Send |
Non-Send type held across .await |
Restructure to drop non-Send values before .await |
the trait bound is not satisfied |
Missing generic constraint | Add trait bound to generic parameter |
no method named X |
Missing trait import | Add use Trait; import |
Borrow Checker Troubleshooting
// Problem: Cannot borrow as mutable because also borrowed as immutable
// Fix: Restructure to end immutable borrow before mutable borrow
let value = map.get("key").cloned(); // Clone ends the immutable borrow
if value.is_none() {
map.insert("key".into(), default_value);
}
// Problem: Value does not live long enough
// Fix: Move ownership instead of borrowing
fn get_name() -> String { // Return owned String
let name = compute_name();
name // Not &name (dangling reference)
}
// Problem: Cannot move out of index
// Fix: Use swap_remove, clone, or take
let item = vec.swap_remove(index); // Takes ownership
// Or: let item = vec[index].clone();
Cargo.toml Troubleshooting
# Check dependency tree for conflicts
cargo tree -d # Show duplicate dependencies
cargo tree -i some_crate # Invert — who depends on this?
# Feature resolution
cargo tree -f "{p} {f}" # Show features enabled per crate
cargo check --features "feat1,feat2" # Test specific feature combination
# Workspace issues
cargo check --workspace # Check all workspace members
cargo check -p specific_crate # Check single crate in workspace
# Lock file issues
cargo update -p specific_crate # Update one dependency (preferred)
cargo update # Full refresh (last resort — broad changes)
Edition and MSRV Issues
# Check edition in Cargo.toml (2024 is the current default for new projects)
grep "edition" Cargo.toml
# Check minimum supported Rust version
rustc --version
grep "rust-version" Cargo.toml
# Common fix: update edition for new syntax (check rust-version first!)
# In Cargo.toml: edition = "2024" # Requires rustc 1.85+
Key Principles
- Surgical fixes only — don't refactor, just fix the error
- Never add
#[allow(unused)]without explicit approval - Never use
unsafeto work around borrow checker errors - Never add
.unwrap()to silence type errors — propagate with? - Always run
cargo checkafter every fix attempt - Fix root cause over suppressing symptoms
- Prefer the simplest fix that preserves the original intent
Stop Conditions
Stop and report if:
- Same error persists after 3 fix attempts
- Fix introduces more errors than it resolves
- Error requires architectural changes beyond scope
- Borrow checker error requires redesigning data ownership model
Output Format
[FIXED] src/handler/user.rs:42
Error: E0502 — cannot borrow `map` as mutable because it is also borrowed as immutable
Fix: Cloned value from immutable borrow before mutable insert
Remaining errors: 3
Final: Build Status: SUCCESS/FAILED | Errors Fixed: N | Files Modified: list
For detailed Rust error patterns and code examples, see skill: rust-patterns.