Files
everything-claude-code/.opencode/commands/rust-review.md
2026-04-05 14:21:57 -07:00

1.8 KiB

description, agent, subtask
description agent subtask
Rust code review for ownership, safety, and idiomatic patterns everything-claude-code:rust-reviewer true

Rust Review Command

Review Rust code for idiomatic patterns and best practices: $ARGUMENTS

Your Task

  1. Analyze Rust code for idioms and patterns
  2. Check ownership - borrowing, lifetimes, unnecessary clones
  3. Review error handling - proper ? propagation, no unwrap in production
  4. Verify safety - unsafe usage, injection, secrets

Review Checklist

Safety (CRITICAL)

  • No unchecked unwrap()/expect() in production paths
  • unsafe blocks have // SAFETY: comments
  • No SQL/command injection
  • No hardcoded secrets

Ownership (HIGH)

  • No unnecessary .clone() to satisfy borrow checker
  • &str preferred over String in function parameters
  • &[T] preferred over Vec<T> in function parameters
  • No excessive lifetime annotations where elision works

Error Handling (HIGH)

  • Errors propagated with ?; use .context() in anyhow/eyre application code
  • No silenced errors (let _ = result;)
  • thiserror for library errors, anyhow for applications

Concurrency (HIGH)

  • No blocking in async context
  • Bounded channels preferred
  • Mutex poisoning handled
  • Send/Sync bounds correct

Code Quality (MEDIUM)

  • Functions under 50 lines
  • No deep nesting (>4 levels)
  • Exhaustive matching on business enums
  • Clippy warnings addressed

Report Format

CRITICAL Issues

  • [file:line] Issue description Suggestion: How to fix

HIGH Issues

  • [file:line] Issue description Suggestion: How to fix

MEDIUM Issues

  • [file:line] Issue description Suggestion: How to fix

TIP: Run cargo clippy -- -D warnings and cargo fmt --check for automated checks.