mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-03-31 06:03:29 +08:00
635eb108ab
Round 111: Tests for parseSessionMetadata context regex truncation at nested triple backticks (lazy [\s\S]*? stops early), getExecCommand accepting newline/tab/CR in args via \s in SAFE_ARGS_REGEX, and setAlias accepting exactly 128-character alias (off-by-one boundary). 893 tests total.
1576 lines
65 KiB
JavaScript
1576 lines
65 KiB
JavaScript
/**
|
|
* Tests for scripts/lib/package-manager.js
|
|
*
|
|
* Run with: node tests/lib/package-manager.test.js
|
|
*/
|
|
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const os = require('os');
|
|
|
|
// Import the modules
|
|
const pm = require('../../scripts/lib/package-manager');
|
|
|
|
// Test helper
|
|
function test(name, fn) {
|
|
try {
|
|
fn();
|
|
console.log(` ✓ ${name}`);
|
|
return true;
|
|
} catch (err) {
|
|
console.log(` ✗ ${name}`);
|
|
console.log(` Error: ${err.message}`);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
// Create a temporary test directory
|
|
function createTestDir() {
|
|
const testDir = path.join(os.tmpdir(), `pm-test-${Date.now()}`);
|
|
fs.mkdirSync(testDir, { recursive: true });
|
|
return testDir;
|
|
}
|
|
|
|
// Clean up test directory
|
|
function cleanupTestDir(testDir) {
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
|
|
// Test suite
|
|
function runTests() {
|
|
console.log('\n=== Testing package-manager.js ===\n');
|
|
|
|
let passed = 0;
|
|
let failed = 0;
|
|
|
|
// PACKAGE_MANAGERS constant tests
|
|
console.log('PACKAGE_MANAGERS Constant:');
|
|
|
|
if (test('PACKAGE_MANAGERS has all expected managers', () => {
|
|
assert.ok(pm.PACKAGE_MANAGERS.npm, 'Should have npm');
|
|
assert.ok(pm.PACKAGE_MANAGERS.pnpm, 'Should have pnpm');
|
|
assert.ok(pm.PACKAGE_MANAGERS.yarn, 'Should have yarn');
|
|
assert.ok(pm.PACKAGE_MANAGERS.bun, 'Should have bun');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('Each manager has required properties', () => {
|
|
const requiredProps = ['name', 'lockFile', 'installCmd', 'runCmd', 'execCmd', 'testCmd', 'buildCmd', 'devCmd'];
|
|
for (const [name, config] of Object.entries(pm.PACKAGE_MANAGERS)) {
|
|
for (const prop of requiredProps) {
|
|
assert.ok(config[prop], `${name} should have ${prop}`);
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// detectFromLockFile tests
|
|
console.log('\ndetectFromLockFile:');
|
|
|
|
if (test('detects npm from package-lock.json', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'package-lock.json'), '{}');
|
|
const result = pm.detectFromLockFile(testDir);
|
|
assert.strictEqual(result, 'npm');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('detects pnpm from pnpm-lock.yaml', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'pnpm-lock.yaml'), '');
|
|
const result = pm.detectFromLockFile(testDir);
|
|
assert.strictEqual(result, 'pnpm');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('detects yarn from yarn.lock', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'yarn.lock'), '');
|
|
const result = pm.detectFromLockFile(testDir);
|
|
assert.strictEqual(result, 'yarn');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('detects bun from bun.lockb', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'bun.lockb'), '');
|
|
const result = pm.detectFromLockFile(testDir);
|
|
assert.strictEqual(result, 'bun');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('returns null when no lock file exists', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
const result = pm.detectFromLockFile(testDir);
|
|
assert.strictEqual(result, null);
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('respects detection priority (pnpm > npm)', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
// Create both lock files
|
|
fs.writeFileSync(path.join(testDir, 'package-lock.json'), '{}');
|
|
fs.writeFileSync(path.join(testDir, 'pnpm-lock.yaml'), '');
|
|
const result = pm.detectFromLockFile(testDir);
|
|
// pnpm has higher priority in DETECTION_PRIORITY
|
|
assert.strictEqual(result, 'pnpm');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// detectFromPackageJson tests
|
|
console.log('\ndetectFromPackageJson:');
|
|
|
|
if (test('detects package manager from packageManager field', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({
|
|
name: 'test',
|
|
packageManager: 'pnpm@8.6.0'
|
|
}));
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, 'pnpm');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('handles packageManager without version', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({
|
|
name: 'test',
|
|
packageManager: 'yarn'
|
|
}));
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, 'yarn');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('returns null when no packageManager field', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({
|
|
name: 'test'
|
|
}));
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, null);
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('returns null when no package.json exists', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, null);
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getAvailablePackageManagers tests
|
|
console.log('\ngetAvailablePackageManagers:');
|
|
|
|
if (test('returns array of available managers', () => {
|
|
const available = pm.getAvailablePackageManagers();
|
|
assert.ok(Array.isArray(available), 'Should return array');
|
|
// npm should always be available with Node.js
|
|
assert.ok(available.includes('npm'), 'npm should be available');
|
|
})) passed++; else failed++;
|
|
|
|
// getPackageManager tests
|
|
console.log('\ngetPackageManager:');
|
|
|
|
if (test('returns object with name, config, and source', () => {
|
|
const result = pm.getPackageManager();
|
|
assert.ok(result.name, 'Should have name');
|
|
assert.ok(result.config, 'Should have config');
|
|
assert.ok(result.source, 'Should have source');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('respects environment variable', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'yarn';
|
|
const result = pm.getPackageManager();
|
|
assert.strictEqual(result.name, 'yarn');
|
|
assert.strictEqual(result.source, 'environment');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('detects from lock file in project', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'bun.lockb'), '');
|
|
const result = pm.getPackageManager({ projectDir: testDir });
|
|
assert.strictEqual(result.name, 'bun');
|
|
assert.strictEqual(result.source, 'lock-file');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getRunCommand tests
|
|
console.log('\ngetRunCommand:');
|
|
|
|
if (test('returns correct install command', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'pnpm';
|
|
const cmd = pm.getRunCommand('install');
|
|
assert.strictEqual(cmd, 'pnpm install');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('returns correct test command', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getRunCommand('test');
|
|
assert.strictEqual(cmd, 'npm test');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getExecCommand tests
|
|
console.log('\ngetExecCommand:');
|
|
|
|
if (test('returns correct exec command for npm', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getExecCommand('prettier', '--write .');
|
|
assert.strictEqual(cmd, 'npx prettier --write .');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('returns correct exec command for pnpm', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'pnpm';
|
|
const cmd = pm.getExecCommand('eslint', '.');
|
|
assert.strictEqual(cmd, 'pnpm dlx eslint .');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getCommandPattern tests
|
|
console.log('\ngetCommandPattern:');
|
|
|
|
if (test('generates pattern for dev command', () => {
|
|
const pattern = pm.getCommandPattern('dev');
|
|
assert.ok(pattern.includes('npm run dev'), 'Should include npm');
|
|
assert.ok(pattern.includes('pnpm'), 'Should include pnpm');
|
|
assert.ok(pattern.includes('yarn dev'), 'Should include yarn');
|
|
assert.ok(pattern.includes('bun run dev'), 'Should include bun');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('pattern matches actual commands', () => {
|
|
const pattern = pm.getCommandPattern('test');
|
|
const regex = new RegExp(pattern);
|
|
|
|
assert.ok(regex.test('npm test'), 'Should match npm test');
|
|
assert.ok(regex.test('pnpm test'), 'Should match pnpm test');
|
|
assert.ok(regex.test('yarn test'), 'Should match yarn test');
|
|
assert.ok(regex.test('bun test'), 'Should match bun test');
|
|
assert.ok(!regex.test('cargo test'), 'Should not match cargo test');
|
|
})) passed++; else failed++;
|
|
|
|
// getSelectionPrompt tests
|
|
console.log('\ngetSelectionPrompt:');
|
|
|
|
if (test('returns informative prompt', () => {
|
|
const prompt = pm.getSelectionPrompt();
|
|
assert.ok(prompt.includes('Supported package managers'), 'Should list supported managers');
|
|
assert.ok(prompt.includes('CLAUDE_PACKAGE_MANAGER'), 'Should mention env var');
|
|
assert.ok(prompt.includes('lock file'), 'Should mention lock file option');
|
|
})) passed++; else failed++;
|
|
|
|
// setProjectPackageManager tests
|
|
console.log('\nsetProjectPackageManager:');
|
|
|
|
if (test('sets project package manager', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
const result = pm.setProjectPackageManager('pnpm', testDir);
|
|
assert.strictEqual(result.packageManager, 'pnpm');
|
|
assert.ok(result.setAt, 'Should have setAt timestamp');
|
|
|
|
// Verify file was created
|
|
const configPath = path.join(testDir, '.claude', 'package-manager.json');
|
|
assert.ok(fs.existsSync(configPath), 'Config file should exist');
|
|
const saved = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
assert.strictEqual(saved.packageManager, 'pnpm');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects unknown package manager', () => {
|
|
assert.throws(() => {
|
|
pm.setProjectPackageManager('cargo');
|
|
}, /Unknown package manager/);
|
|
})) passed++; else failed++;
|
|
|
|
// setPreferredPackageManager tests
|
|
console.log('\nsetPreferredPackageManager:');
|
|
|
|
if (test('rejects unknown package manager', () => {
|
|
assert.throws(() => {
|
|
pm.setPreferredPackageManager('pip');
|
|
}, /Unknown package manager/);
|
|
})) passed++; else failed++;
|
|
|
|
// detectFromPackageJson edge cases
|
|
console.log('\ndetectFromPackageJson (edge cases):');
|
|
|
|
if (test('handles invalid JSON in package.json', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'package.json'), 'NOT VALID JSON');
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, null);
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('returns null for unknown package manager in packageManager field', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({
|
|
name: 'test',
|
|
packageManager: 'deno@1.0'
|
|
}));
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, null);
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getExecCommand edge cases
|
|
console.log('\ngetExecCommand (edge cases):');
|
|
|
|
if (test('returns exec command without args', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getExecCommand('prettier');
|
|
assert.strictEqual(cmd, 'npx prettier');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getRunCommand additional cases
|
|
console.log('\ngetRunCommand (additional):');
|
|
|
|
if (test('returns correct build command', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
assert.strictEqual(pm.getRunCommand('build'), 'npm run build');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('returns correct dev command', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
assert.strictEqual(pm.getRunCommand('dev'), 'npm run dev');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('returns correct custom script command', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
assert.strictEqual(pm.getRunCommand('lint'), 'npm run lint');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// DETECTION_PRIORITY tests
|
|
console.log('\nDETECTION_PRIORITY:');
|
|
|
|
if (test('has pnpm first', () => {
|
|
assert.strictEqual(pm.DETECTION_PRIORITY[0], 'pnpm');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('has npm last', () => {
|
|
assert.strictEqual(pm.DETECTION_PRIORITY[pm.DETECTION_PRIORITY.length - 1], 'npm');
|
|
})) passed++; else failed++;
|
|
|
|
// getCommandPattern additional cases
|
|
console.log('\ngetCommandPattern (additional):');
|
|
|
|
if (test('generates pattern for install command', () => {
|
|
const pattern = pm.getCommandPattern('install');
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test('npm install'), 'Should match npm install');
|
|
assert.ok(regex.test('pnpm install'), 'Should match pnpm install');
|
|
assert.ok(regex.test('yarn'), 'Should match yarn (install implicit)');
|
|
assert.ok(regex.test('bun install'), 'Should match bun install');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('generates pattern for custom action', () => {
|
|
const pattern = pm.getCommandPattern('lint');
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test('npm run lint'), 'Should match npm run lint');
|
|
assert.ok(regex.test('pnpm lint'), 'Should match pnpm lint');
|
|
assert.ok(regex.test('yarn lint'), 'Should match yarn lint');
|
|
assert.ok(regex.test('bun run lint'), 'Should match bun run lint');
|
|
})) passed++; else failed++;
|
|
|
|
// getPackageManager robustness tests
|
|
console.log('\ngetPackageManager (robustness):');
|
|
|
|
if (test('falls through on corrupted project config JSON', () => {
|
|
const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-robust-'));
|
|
const claudeDir = path.join(testDir, '.claude');
|
|
fs.mkdirSync(claudeDir, { recursive: true });
|
|
fs.writeFileSync(path.join(claudeDir, 'package-manager.json'), '{not valid json!!!');
|
|
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
const result = pm.getPackageManager({ projectDir: testDir });
|
|
// Should fall through to default (npm) since project config is corrupt
|
|
assert.ok(result.name, 'Should return a package manager');
|
|
assert.ok(result.source !== 'project-config', 'Should not use corrupt project config');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
}
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('falls through on project config with unknown PM', () => {
|
|
const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-robust-'));
|
|
const claudeDir = path.join(testDir, '.claude');
|
|
fs.mkdirSync(claudeDir, { recursive: true });
|
|
fs.writeFileSync(path.join(claudeDir, 'package-manager.json'),
|
|
JSON.stringify({ packageManager: 'nonexistent-pm' }));
|
|
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
const result = pm.getPackageManager({ projectDir: testDir });
|
|
assert.ok(result.name, 'Should return a package manager');
|
|
assert.ok(result.source !== 'project-config', 'Should not use unknown PM config');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
}
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getRunCommand validation tests
|
|
console.log('\ngetRunCommand (validation):');
|
|
|
|
if (test('rejects empty script name', () => {
|
|
assert.throws(() => pm.getRunCommand(''), /non-empty string/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects null script name', () => {
|
|
assert.throws(() => pm.getRunCommand(null), /non-empty string/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects script name with shell metacharacters', () => {
|
|
assert.throws(() => pm.getRunCommand('test; rm -rf /'), /unsafe characters/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects script name with backticks', () => {
|
|
assert.throws(() => pm.getRunCommand('test`whoami`'), /unsafe characters/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('accepts scoped package names', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getRunCommand('@scope/my-script');
|
|
assert.strictEqual(cmd, 'npm run @scope/my-script');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getExecCommand validation tests
|
|
console.log('\ngetExecCommand (validation):');
|
|
|
|
if (test('rejects empty binary name', () => {
|
|
assert.throws(() => pm.getExecCommand(''), /non-empty string/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects null binary name', () => {
|
|
assert.throws(() => pm.getExecCommand(null), /non-empty string/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects binary name with shell metacharacters', () => {
|
|
assert.throws(() => pm.getExecCommand('prettier; cat /etc/passwd'), /unsafe characters/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('accepts dotted binary names like tsc', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getExecCommand('tsc');
|
|
assert.strictEqual(cmd, 'npx tsc');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getPackageManager source detection tests
|
|
console.log('\ngetPackageManager (source detection):');
|
|
|
|
if (test('detects from valid project-config (.claude/package-manager.json)', () => {
|
|
const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-projcfg-'));
|
|
const claudeDir = path.join(testDir, '.claude');
|
|
fs.mkdirSync(claudeDir, { recursive: true });
|
|
fs.writeFileSync(path.join(claudeDir, 'package-manager.json'),
|
|
JSON.stringify({ packageManager: 'pnpm' }));
|
|
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
const result = pm.getPackageManager({ projectDir: testDir });
|
|
assert.strictEqual(result.name, 'pnpm', 'Should detect pnpm from project config');
|
|
assert.strictEqual(result.source, 'project-config', 'Source should be project-config');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
}
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('project-config takes priority over package.json', () => {
|
|
const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-priority-'));
|
|
const claudeDir = path.join(testDir, '.claude');
|
|
fs.mkdirSync(claudeDir, { recursive: true });
|
|
|
|
// Project config says bun
|
|
fs.writeFileSync(path.join(claudeDir, 'package-manager.json'),
|
|
JSON.stringify({ packageManager: 'bun' }));
|
|
// package.json says yarn
|
|
fs.writeFileSync(path.join(testDir, 'package.json'),
|
|
JSON.stringify({ packageManager: 'yarn@4.0.0' }));
|
|
// Lock file says npm
|
|
fs.writeFileSync(path.join(testDir, 'package-lock.json'), '{}');
|
|
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
const result = pm.getPackageManager({ projectDir: testDir });
|
|
assert.strictEqual(result.name, 'bun', 'Project config should win over package.json and lock file');
|
|
assert.strictEqual(result.source, 'project-config');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
}
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('package.json takes priority over lock file', () => {
|
|
const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-pj-lock-'));
|
|
// package.json says yarn
|
|
fs.writeFileSync(path.join(testDir, 'package.json'),
|
|
JSON.stringify({ packageManager: 'yarn@4.0.0' }));
|
|
// Lock file says npm
|
|
fs.writeFileSync(path.join(testDir, 'package-lock.json'), '{}');
|
|
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
const result = pm.getPackageManager({ projectDir: testDir });
|
|
assert.strictEqual(result.name, 'yarn', 'package.json should win over lock file');
|
|
assert.strictEqual(result.source, 'package.json');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
}
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('defaults to npm when no config found', () => {
|
|
const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-default-'));
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
const result = pm.getPackageManager({ projectDir: testDir });
|
|
assert.strictEqual(result.name, 'npm', 'Should default to npm');
|
|
assert.strictEqual(result.source, 'default');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
}
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// setPreferredPackageManager success
|
|
console.log('\nsetPreferredPackageManager (success):');
|
|
|
|
if (test('successfully saves preferred package manager', () => {
|
|
// This writes to ~/.claude/package-manager.json — read original to restore
|
|
const utils = require('../../scripts/lib/utils');
|
|
const configPath = path.join(utils.getClaudeDir(), 'package-manager.json');
|
|
const original = utils.readFile(configPath);
|
|
try {
|
|
const config = pm.setPreferredPackageManager('bun');
|
|
assert.strictEqual(config.packageManager, 'bun');
|
|
assert.ok(config.setAt, 'Should have setAt timestamp');
|
|
// Verify it was persisted
|
|
const saved = JSON.parse(fs.readFileSync(configPath, 'utf8'));
|
|
assert.strictEqual(saved.packageManager, 'bun');
|
|
} finally {
|
|
// Restore original config
|
|
if (original) {
|
|
fs.writeFileSync(configPath, original, 'utf8');
|
|
} else {
|
|
try { fs.unlinkSync(configPath); } catch {}
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getCommandPattern completeness
|
|
console.log('\ngetCommandPattern (completeness):');
|
|
|
|
if (test('generates pattern for test command', () => {
|
|
const pattern = pm.getCommandPattern('test');
|
|
assert.ok(pattern.includes('npm test'), 'Should include npm test');
|
|
assert.ok(pattern.includes('pnpm test'), 'Should include pnpm test');
|
|
assert.ok(pattern.includes('bun test'), 'Should include bun test');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('generates pattern for build command', () => {
|
|
const pattern = pm.getCommandPattern('build');
|
|
assert.ok(pattern.includes('npm run build'), 'Should include npm run build');
|
|
assert.ok(pattern.includes('yarn build'), 'Should include yarn build');
|
|
})) passed++; else failed++;
|
|
|
|
// getRunCommand PM-specific format tests
|
|
console.log('\ngetRunCommand (PM-specific formats):');
|
|
|
|
if (test('pnpm custom script: pnpm <script> (no run keyword)', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'pnpm';
|
|
const cmd = pm.getRunCommand('lint');
|
|
assert.strictEqual(cmd, 'pnpm lint', 'pnpm uses "pnpm <script>" format');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('yarn custom script: yarn <script>', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'yarn';
|
|
const cmd = pm.getRunCommand('format');
|
|
assert.strictEqual(cmd, 'yarn format', 'yarn uses "yarn <script>" format');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('bun custom script: bun run <script>', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'bun';
|
|
const cmd = pm.getRunCommand('typecheck');
|
|
assert.strictEqual(cmd, 'bun run typecheck', 'bun uses "bun run <script>" format');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('npm custom script: npm run <script>', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getRunCommand('lint');
|
|
assert.strictEqual(cmd, 'npm run lint', 'npm uses "npm run <script>" format');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('pnpm install returns pnpm install', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'pnpm';
|
|
assert.strictEqual(pm.getRunCommand('install'), 'pnpm install');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('yarn install returns yarn (no install keyword)', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'yarn';
|
|
assert.strictEqual(pm.getRunCommand('install'), 'yarn');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('bun test returns bun test', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'bun';
|
|
assert.strictEqual(pm.getRunCommand('test'), 'bun test');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getExecCommand PM-specific format tests
|
|
console.log('\ngetExecCommand (PM-specific formats):');
|
|
|
|
if (test('pnpm exec: pnpm dlx <binary>', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'pnpm';
|
|
assert.strictEqual(pm.getExecCommand('prettier', '--write .'), 'pnpm dlx prettier --write .');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('yarn exec: yarn dlx <binary>', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'yarn';
|
|
assert.strictEqual(pm.getExecCommand('eslint', '.'), 'yarn dlx eslint .');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('bun exec: bunx <binary>', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'bun';
|
|
assert.strictEqual(pm.getExecCommand('tsc', '--noEmit'), 'bunx tsc --noEmit');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('ignores unknown env var package manager', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'totally-fake-pm';
|
|
const result = pm.getPackageManager();
|
|
// Should ignore invalid env var and fall through
|
|
assert.notStrictEqual(result.name, 'totally-fake-pm', 'Should not use unknown PM');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ─── Round 21: getExecCommand args validation ───
|
|
console.log('\ngetExecCommand (args validation):');
|
|
|
|
if (test('rejects args with shell metacharacter semicolon', () => {
|
|
assert.throws(() => pm.getExecCommand('prettier', '; rm -rf /'), /unsafe characters/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects args with pipe character', () => {
|
|
assert.throws(() => pm.getExecCommand('prettier', '--write . | cat'), /unsafe characters/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects args with backtick injection', () => {
|
|
assert.throws(() => pm.getExecCommand('prettier', '`whoami`'), /unsafe characters/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects args with dollar sign', () => {
|
|
assert.throws(() => pm.getExecCommand('prettier', '$HOME'), /unsafe characters/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects args with ampersand', () => {
|
|
assert.throws(() => pm.getExecCommand('prettier', '--write . && echo pwned'), /unsafe characters/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('allows safe args like --write .', () => {
|
|
const cmd = pm.getExecCommand('prettier', '--write .');
|
|
assert.ok(cmd.includes('--write .'), 'Should include safe args');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('allows empty args without trailing space', () => {
|
|
const cmd = pm.getExecCommand('prettier', '');
|
|
assert.ok(!cmd.endsWith(' '), 'Should not have trailing space for empty args');
|
|
})) passed++; else failed++;
|
|
|
|
// ─── Round 21: getCommandPattern regex escaping ───
|
|
console.log('\ngetCommandPattern (regex escaping):');
|
|
|
|
if (test('escapes dot in action name for regex safety', () => {
|
|
const pattern = pm.getCommandPattern('test.all');
|
|
// The dot should be escaped to \\. in the pattern
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test('npm run test.all'), 'Should match literal dot');
|
|
assert.ok(!regex.test('npm run testXall'), 'Should NOT match arbitrary character in place of dot');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('escapes brackets in action name', () => {
|
|
const pattern = pm.getCommandPattern('build[prod]');
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test('npm run build[prod]'), 'Should match literal brackets');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('escapes parentheses in action name', () => {
|
|
// Should not throw when compiled as regex
|
|
const pattern = pm.getCommandPattern('foo(bar)');
|
|
assert.doesNotThrow(() => new RegExp(pattern), 'Should produce valid regex with escaped parens');
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 27: input validation and escapeRegex edge cases ──
|
|
console.log('\ngetRunCommand (non-string input):');
|
|
|
|
if (test('rejects undefined script name', () => {
|
|
assert.throws(() => pm.getRunCommand(undefined), /non-empty string/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects numeric script name', () => {
|
|
assert.throws(() => pm.getRunCommand(123), /non-empty string/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects boolean script name', () => {
|
|
assert.throws(() => pm.getRunCommand(true), /non-empty string/);
|
|
})) passed++; else failed++;
|
|
|
|
console.log('\ngetExecCommand (non-string binary):');
|
|
|
|
if (test('rejects undefined binary name', () => {
|
|
assert.throws(() => pm.getExecCommand(undefined), /non-empty string/);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('rejects numeric binary name', () => {
|
|
assert.throws(() => pm.getExecCommand(42), /non-empty string/);
|
|
})) passed++; else failed++;
|
|
|
|
console.log('\ngetCommandPattern (escapeRegex completeness):');
|
|
|
|
if (test('escapes all regex metacharacters in action', () => {
|
|
// All regex metacharacters: . * + ? ^ $ { } ( ) | [ ] \
|
|
const action = 'test.*+?^${}()|[]\\';
|
|
const pattern = pm.getCommandPattern(action);
|
|
// Should produce a valid regex without throwing
|
|
assert.doesNotThrow(() => new RegExp(pattern), 'Should produce valid regex');
|
|
// Should match the literal string
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test(`npm run ${action}`), 'Should match literal metacharacters');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('escapeRegex preserves alphanumeric chars', () => {
|
|
const pattern = pm.getCommandPattern('simple-test');
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test('npm run simple-test'), 'Should match simple action name');
|
|
assert.ok(!regex.test('npm run simpleXtest'), 'Dash should not match arbitrary char');
|
|
})) passed++; else failed++;
|
|
|
|
console.log('\ngetPackageManager (global config edge cases):');
|
|
|
|
if (test('ignores global config with non-string packageManager', () => {
|
|
// This tests the path through loadConfig where packageManager is not a valid PM name
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
// getPackageManager should fall through to default when no valid config exists
|
|
const result = pm.getPackageManager({ projectDir: os.tmpdir() });
|
|
assert.ok(result.name, 'Should return a package manager name');
|
|
assert.ok(result.config, 'Should return config object');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 30: getCommandPattern with special action patterns ──
|
|
console.log('\nRound 30: getCommandPattern edge cases:');
|
|
|
|
if (test('escapes pipe character in action name', () => {
|
|
const pattern = pm.getCommandPattern('lint|fix');
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test('npm run lint|fix'), 'Should match literal pipe');
|
|
assert.ok(!regex.test('npm run lint'), 'Pipe should be literal, not regex OR');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('escapes dollar sign in action name', () => {
|
|
const pattern = pm.getCommandPattern('deploy$prod');
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test('npm run deploy$prod'), 'Should match literal dollar sign');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('handles action with leading/trailing spaces gracefully', () => {
|
|
// Spaces aren't special in regex but good to test the full pattern
|
|
const pattern = pm.getCommandPattern(' dev ');
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test('npm run dev '), 'Should match action with spaces');
|
|
})) passed++; else failed++;
|
|
|
|
if (test('known action "dev" does NOT use escapeRegex path', () => {
|
|
// "dev" is a known action with hardcoded patterns, not the generic path
|
|
const pattern = pm.getCommandPattern('dev');
|
|
// Should match pnpm dev (without "run")
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex.test('pnpm dev'), 'Known action pnpm dev should match');
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 31: setProjectPackageManager write verification ──
|
|
console.log('\nsetProjectPackageManager (write verification, Round 31):');
|
|
|
|
if (test('setProjectPackageManager creates .claude directory if missing', () => {
|
|
const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-mkdir-'));
|
|
try {
|
|
const claudeDir = path.join(testDir, '.claude');
|
|
assert.ok(!fs.existsSync(claudeDir), '.claude should not pre-exist');
|
|
pm.setProjectPackageManager('npm', testDir);
|
|
assert.ok(fs.existsSync(claudeDir), '.claude should be created');
|
|
const configPath = path.join(claudeDir, 'package-manager.json');
|
|
assert.ok(fs.existsSync(configPath), 'Config file should be created');
|
|
} finally {
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('setProjectPackageManager includes setAt timestamp', () => {
|
|
const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pm-ts-'));
|
|
try {
|
|
const before = new Date().toISOString();
|
|
const config = pm.setProjectPackageManager('yarn', testDir);
|
|
const after = new Date().toISOString();
|
|
assert.ok(config.setAt >= before, 'setAt should be >= before');
|
|
assert.ok(config.setAt <= after, 'setAt should be <= after');
|
|
} finally {
|
|
fs.rmSync(testDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 31: getExecCommand safe argument edge cases ──
|
|
console.log('\ngetExecCommand (safe argument edge cases, Round 31):');
|
|
|
|
if (test('allows colons in args (e.g. --fix:all)', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getExecCommand('eslint', '--fix:all');
|
|
assert.ok(cmd.includes('--fix:all'), 'Colons should be allowed in args');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('allows at-sign in args (e.g. @latest)', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getExecCommand('create-next-app', '@latest');
|
|
assert.ok(cmd.includes('@latest'), 'At-sign should be allowed in args');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('allows equals in args (e.g. --config=path)', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getExecCommand('prettier', '--config=.prettierrc');
|
|
assert.ok(cmd.includes('--config=.prettierrc'), 'Equals should be allowed');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 34: getExecCommand non-string args & packageManager type ──
|
|
console.log('\nRound 34: getExecCommand non-string args:');
|
|
|
|
if (test('getExecCommand with args=0 produces command without extra args', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getExecCommand('prettier', 0);
|
|
// 0 is falsy, so ternary `args ? ' ' + args : ''` yields ''
|
|
assert.ok(!cmd.includes(' 0'), 'Should not append 0 as args');
|
|
assert.ok(cmd.includes('prettier'), 'Should include binary name');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('getExecCommand with args=false produces command without extra args', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getExecCommand('eslint', false);
|
|
assert.ok(!cmd.includes('false'), 'Should not append false as args');
|
|
assert.ok(cmd.includes('eslint'), 'Should include binary name');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('getExecCommand with args=null produces command without extra args', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
const cmd = pm.getExecCommand('tsc', null);
|
|
assert.ok(!cmd.includes('null'), 'Should not append null as args');
|
|
assert.ok(cmd.includes('tsc'), 'Should include binary name');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
console.log('\nRound 34: detectFromPackageJson with non-string packageManager:');
|
|
|
|
if (test('detectFromPackageJson handles array packageManager field gracefully', () => {
|
|
const tmpDir = createTestDir();
|
|
try {
|
|
// Write a malformed package.json with array instead of string
|
|
fs.writeFileSync(path.join(tmpDir, 'package.json'),
|
|
JSON.stringify({ packageManager: ['pnpm@8', 'yarn@3'] }));
|
|
// Should not crash — try/catch in detectFromPackageJson catches TypeError
|
|
const result = pm.getPackageManager({ projectDir: tmpDir });
|
|
assert.ok(result.name, 'Should fallback to a valid package manager');
|
|
} finally {
|
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('detectFromPackageJson handles numeric packageManager field gracefully', () => {
|
|
const tmpDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(tmpDir, 'package.json'),
|
|
JSON.stringify({ packageManager: 42 }));
|
|
const result = pm.getPackageManager({ projectDir: tmpDir });
|
|
assert.ok(result.name, 'Should fallback to a valid package manager');
|
|
} finally {
|
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 48: detectFromPackageJson format edge cases ──
|
|
console.log('\nRound 48: detectFromPackageJson (version format edge cases):');
|
|
|
|
if (test('returns null for packageManager with non-@ separator', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({
|
|
name: 'test',
|
|
packageManager: 'pnpm+8.6.0'
|
|
}));
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
// split('@') on 'pnpm+8.6.0' returns ['pnpm+8.6.0'], which doesn't match PACKAGE_MANAGERS
|
|
assert.strictEqual(result, null, 'Non-@ format should not match any package manager');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
if (test('extracts package manager from caret version like yarn@^4.0.0', () => {
|
|
const testDir = createTestDir();
|
|
try {
|
|
fs.writeFileSync(path.join(testDir, 'package.json'), JSON.stringify({
|
|
name: 'test',
|
|
packageManager: 'yarn@^4.0.0'
|
|
}));
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, 'yarn', 'Caret version should still extract PM name');
|
|
} finally {
|
|
cleanupTestDir(testDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// getPackageManager falls through corrupted global config to npm default
|
|
if (test('getPackageManager falls through corrupted global config to npm default', () => {
|
|
const tmpDir = createTestDir();
|
|
const projDir = path.join(tmpDir, 'proj');
|
|
fs.mkdirSync(projDir, { recursive: true });
|
|
const origHome = process.env.HOME;
|
|
const origUserProfile = process.env.USERPROFILE;
|
|
const origPM = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
// Create corrupted global config file
|
|
const claudeDir = path.join(tmpDir, '.claude');
|
|
fs.mkdirSync(claudeDir, { recursive: true });
|
|
fs.writeFileSync(path.join(claudeDir, 'package-manager.json'), '{ invalid json !!!', 'utf8');
|
|
process.env.HOME = tmpDir;
|
|
process.env.USERPROFILE = tmpDir;
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
// Re-require to pick up new HOME
|
|
delete require.cache[require.resolve('../../scripts/lib/package-manager')];
|
|
delete require.cache[require.resolve('../../scripts/lib/utils')];
|
|
const freshPM = require('../../scripts/lib/package-manager');
|
|
// Empty project dir: no lock file, no package.json, no project config
|
|
const result = freshPM.getPackageManager({ projectDir: projDir });
|
|
assert.strictEqual(result.name, 'npm', 'Should fall through to npm default');
|
|
assert.strictEqual(result.source, 'default', 'Source should be default');
|
|
} finally {
|
|
process.env.HOME = origHome;
|
|
process.env.USERPROFILE = origUserProfile;
|
|
if (origPM !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = origPM;
|
|
delete require.cache[require.resolve('../../scripts/lib/package-manager')];
|
|
delete require.cache[require.resolve('../../scripts/lib/utils')];
|
|
cleanupTestDir(tmpDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 69: getPackageManager global-config success path ──
|
|
console.log('\nRound 69: getPackageManager (global-config success):');
|
|
|
|
if (test('getPackageManager returns source global-config when valid global config exists', () => {
|
|
const tmpDir = createTestDir();
|
|
const projDir = path.join(tmpDir, 'proj');
|
|
fs.mkdirSync(projDir, { recursive: true });
|
|
const origHome = process.env.HOME;
|
|
const origUserProfile = process.env.USERPROFILE;
|
|
const origPM = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
// Create valid global config with pnpm preference
|
|
const claudeDir = path.join(tmpDir, '.claude');
|
|
fs.mkdirSync(claudeDir, { recursive: true });
|
|
fs.writeFileSync(path.join(claudeDir, 'package-manager.json'),
|
|
JSON.stringify({ packageManager: 'pnpm', setAt: '2026-01-01T00:00:00Z' }), 'utf8');
|
|
process.env.HOME = tmpDir;
|
|
process.env.USERPROFILE = tmpDir;
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
// Re-require to pick up new HOME
|
|
delete require.cache[require.resolve('../../scripts/lib/package-manager')];
|
|
delete require.cache[require.resolve('../../scripts/lib/utils')];
|
|
const freshPM = require('../../scripts/lib/package-manager');
|
|
// Empty project dir: no lock file, no package.json, no project config
|
|
const result = freshPM.getPackageManager({ projectDir: projDir });
|
|
assert.strictEqual(result.name, 'pnpm', 'Should detect pnpm from global config');
|
|
assert.strictEqual(result.source, 'global-config', 'Source should be global-config');
|
|
assert.ok(result.config, 'Should include config object');
|
|
assert.strictEqual(result.config.lockFile, 'pnpm-lock.yaml', 'Config should match pnpm');
|
|
} finally {
|
|
process.env.HOME = origHome;
|
|
process.env.USERPROFILE = origUserProfile;
|
|
if (origPM !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = origPM;
|
|
delete require.cache[require.resolve('../../scripts/lib/package-manager')];
|
|
delete require.cache[require.resolve('../../scripts/lib/utils')];
|
|
cleanupTestDir(tmpDir);
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 71: setPreferredPackageManager save failure wraps error ──
|
|
console.log('\nRound 71: setPreferredPackageManager (save failure):');
|
|
|
|
if (test('setPreferredPackageManager throws wrapped error when save fails', () => {
|
|
if (process.platform === 'win32' || process.getuid?.() === 0) {
|
|
console.log(' (skipped — chmod ineffective on Windows/root)');
|
|
return;
|
|
}
|
|
const isoHome = path.join(os.tmpdir(), `ecc-pm-r71-${Date.now()}`);
|
|
const claudeDir = path.join(isoHome, '.claude');
|
|
fs.mkdirSync(claudeDir, { recursive: true });
|
|
|
|
const savedHome = process.env.HOME;
|
|
const savedProfile = process.env.USERPROFILE;
|
|
try {
|
|
process.env.HOME = isoHome;
|
|
process.env.USERPROFILE = isoHome;
|
|
delete require.cache[require.resolve('../../scripts/lib/package-manager')];
|
|
delete require.cache[require.resolve('../../scripts/lib/utils')];
|
|
const freshPm = require('../../scripts/lib/package-manager');
|
|
|
|
// Make .claude directory read-only — can't create new files (package-manager.json)
|
|
fs.chmodSync(claudeDir, 0o555);
|
|
|
|
assert.throws(() => {
|
|
freshPm.setPreferredPackageManager('npm');
|
|
}, /Failed to save package manager preference/);
|
|
} finally {
|
|
try { fs.chmodSync(claudeDir, 0o755); } catch { /* best-effort */ }
|
|
process.env.HOME = savedHome;
|
|
process.env.USERPROFILE = savedProfile;
|
|
delete require.cache[require.resolve('../../scripts/lib/package-manager')];
|
|
delete require.cache[require.resolve('../../scripts/lib/utils')];
|
|
fs.rmSync(isoHome, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 72: setProjectPackageManager save failure wraps error ──
|
|
console.log('\nRound 72: setProjectPackageManager (save failure):');
|
|
|
|
if (test('setProjectPackageManager throws wrapped error when write fails', () => {
|
|
if (process.platform === 'win32' || process.getuid?.() === 0) {
|
|
console.log(' (skipped — chmod ineffective on Windows/root)');
|
|
return;
|
|
}
|
|
const isoProject = path.join(os.tmpdir(), `ecc-pm-proj-r72-${Date.now()}`);
|
|
const claudeDir = path.join(isoProject, '.claude');
|
|
fs.mkdirSync(claudeDir, { recursive: true });
|
|
|
|
// Make .claude directory read-only — can't create new files
|
|
fs.chmodSync(claudeDir, 0o555);
|
|
|
|
try {
|
|
assert.throws(() => {
|
|
pm.setProjectPackageManager('npm', isoProject);
|
|
}, /Failed to save package manager config/);
|
|
} finally {
|
|
fs.chmodSync(claudeDir, 0o755);
|
|
fs.rmSync(isoProject, { recursive: true, force: true });
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 80: getExecCommand with truthy non-string args ──
|
|
console.log('\nRound 80: getExecCommand (truthy non-string args):');
|
|
|
|
if (test('getExecCommand with args=42 (truthy number) appends stringified value', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
// args=42: truthy, so typeof check at line 334 short-circuits
|
|
// (typeof 42 !== 'string'), skipping validation. Line 339:
|
|
// 42 ? ' ' + 42 → ' 42' → appended.
|
|
const cmd = pm.getExecCommand('prettier', 42);
|
|
assert.ok(cmd.includes('prettier'), 'Should include binary name');
|
|
assert.ok(cmd.includes('42'), 'Truthy number should be stringified and appended');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 86: detectFromPackageJson with empty (0-byte) package.json ──
|
|
console.log('\nRound 86: detectFromPackageJson (empty package.json):');
|
|
|
|
if (test('detectFromPackageJson returns null for empty (0-byte) package.json', () => {
|
|
// package-manager.js line 109-111: readFile returns "" for empty file.
|
|
// "" is falsy → if (content) is false → skips JSON.parse → returns null.
|
|
const testDir = createTestDir();
|
|
fs.writeFileSync(path.join(testDir, 'package.json'), '');
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, null, 'Empty package.json should return null (content="" is falsy)');
|
|
cleanupTestDir(testDir);
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 91: getCommandPattern with empty action string ──
|
|
console.log('\nRound 91: getCommandPattern (empty action):');
|
|
|
|
if (test('getCommandPattern with empty string returns valid regex pattern', () => {
|
|
// package-manager.js line 401-409: Empty action falls to the else branch.
|
|
// escapeRegex('') returns '', producing patterns like 'npm run ', 'yarn '.
|
|
// The resulting combined regex should be compilable (not throw).
|
|
const pattern = pm.getCommandPattern('');
|
|
assert.ok(typeof pattern === 'string', 'Should return a string');
|
|
assert.ok(pattern.length > 0, 'Should return non-empty pattern');
|
|
// Verify the pattern compiles without error
|
|
const regex = new RegExp(pattern);
|
|
assert.ok(regex instanceof RegExp, 'Pattern should compile to valid RegExp');
|
|
// The pattern should match package manager commands with trailing space
|
|
assert.ok(regex.test('npm run '), 'Should match "npm run " with trailing space');
|
|
assert.ok(regex.test('yarn '), 'Should match "yarn " with trailing space');
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 91: detectFromPackageJson with whitespace-only packageManager ──
|
|
console.log('\nRound 91: detectFromPackageJson (whitespace-only packageManager):');
|
|
|
|
if (test('detectFromPackageJson returns null for whitespace-only packageManager field', () => {
|
|
// package-manager.js line 114-119: " " is truthy, so enters the if block.
|
|
// " ".split('@')[0] = " " which doesn't match any PACKAGE_MANAGERS key.
|
|
const testDir = createTestDir();
|
|
fs.writeFileSync(
|
|
path.join(testDir, 'package.json'),
|
|
JSON.stringify({ packageManager: ' ' }));
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, null, 'Whitespace-only packageManager should return null');
|
|
cleanupTestDir(testDir);
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 92: detectFromPackageJson with empty string packageManager ──
|
|
console.log('\nRound 92: detectFromPackageJson (empty string packageManager):');
|
|
|
|
if (test('detectFromPackageJson returns null for empty string packageManager field', () => {
|
|
// package-manager.js line 114: if (pkg.packageManager) — empty string "" is falsy,
|
|
// so the if block is skipped entirely. Function returns null without attempting split.
|
|
// This is distinct from Round 91's whitespace test (" " is truthy and enters the if).
|
|
const testDir = createTestDir();
|
|
fs.writeFileSync(
|
|
path.join(testDir, 'package.json'),
|
|
JSON.stringify({ name: 'test', packageManager: '' }));
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, null, 'Empty string packageManager should return null (falsy)');
|
|
cleanupTestDir(testDir);
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 94: detectFromPackageJson with scoped package name ──
|
|
console.log('\nRound 94: detectFromPackageJson (scoped package name @scope/pkg@version):');
|
|
|
|
if (test('detectFromPackageJson returns null for scoped package name (@scope/pkg@version)', () => {
|
|
// package-manager.js line 116: pmName = pkg.packageManager.split('@')[0]
|
|
// For "@pnpm/exe@8.0.0", split('@') → ['', 'pnpm/exe', '8.0.0'], so [0] = ''
|
|
// PACKAGE_MANAGERS[''] is undefined → returns null.
|
|
// Scoped npm packages like @pnpm/exe are a real-world pattern but the
|
|
// packageManager field spec uses unscoped names (e.g., "pnpm@8"), so returning
|
|
// null is the correct defensive behaviour for this edge case.
|
|
const testDir = createTestDir();
|
|
fs.writeFileSync(
|
|
path.join(testDir, 'package.json'),
|
|
JSON.stringify({ name: 'test', packageManager: '@pnpm/exe@8.0.0' }));
|
|
const result = pm.detectFromPackageJson(testDir);
|
|
assert.strictEqual(result, null,
|
|
'Scoped package name should return null (split("@")[0] is empty string)');
|
|
cleanupTestDir(testDir);
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 94: getPackageManager with empty string CLAUDE_PACKAGE_MANAGER ──
|
|
console.log('\nRound 94: getPackageManager (empty string CLAUDE_PACKAGE_MANAGER env var):');
|
|
|
|
if (test('getPackageManager skips empty string CLAUDE_PACKAGE_MANAGER (falsy short-circuit)', () => {
|
|
// package-manager.js line 168: if (envPm && PACKAGE_MANAGERS[envPm])
|
|
// Empty string '' is falsy — the && short-circuits before checking PACKAGE_MANAGERS.
|
|
// This is distinct from the 'totally-fake-pm' test (truthy but unknown PM).
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = '';
|
|
const result = pm.getPackageManager();
|
|
assert.notStrictEqual(result.source, 'environment',
|
|
'Empty string env var should NOT be treated as environment source');
|
|
assert.ok(result.name, 'Should still return a valid package manager name');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 104: detectFromLockFile with null projectDir (no input validation) ──
|
|
console.log('\nRound 104: detectFromLockFile (null projectDir — throws TypeError):');
|
|
if (test('detectFromLockFile(null) throws TypeError (path.join rejects null)', () => {
|
|
// package-manager.js line 95: `path.join(projectDir, pm.lockFile)` — there is no
|
|
// guard checking that projectDir is a string before passing it to path.join().
|
|
// When projectDir is null, path.join(null, 'package-lock.json') throws a TypeError
|
|
// because path.join only accepts string arguments.
|
|
assert.throws(
|
|
() => pm.detectFromLockFile(null),
|
|
{ name: 'TypeError' },
|
|
'path.join(null, ...) should throw TypeError (no input validation in detectFromLockFile)'
|
|
);
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 105: getExecCommand with object args (bypasses SAFE_ARGS_REGEX, coerced to [object Object]) ──
|
|
console.log('\nRound 105: getExecCommand (object args — typeof bypass coerces to [object Object]):');
|
|
|
|
if (test('getExecCommand with args={} bypasses SAFE_ARGS validation and coerces to "[object Object]"', () => {
|
|
// package-manager.js line 334: `if (args && typeof args === 'string' && !SAFE_ARGS_REGEX.test(args))`
|
|
// When args is an object: typeof {} === 'object' (not 'string'), so the
|
|
// SAFE_ARGS_REGEX check is entirely SKIPPED.
|
|
// Line 339: `args ? ' ' + args : ''` — object is truthy, so it reaches
|
|
// string concatenation which calls {}.toString() → "[object Object]"
|
|
// Final command: "npx prettier [object Object]" — brackets bypass validation.
|
|
const cmd = pm.getExecCommand('prettier', {});
|
|
assert.ok(cmd.includes('[object Object]'),
|
|
'Object args should be coerced to "[object Object]" via implicit toString()');
|
|
// Verify the SAFE_ARGS regex WOULD reject this string if it were a string arg
|
|
assert.throws(
|
|
() => pm.getExecCommand('prettier', '[object Object]'),
|
|
/unsafe characters/,
|
|
'Same string as explicit string arg is correctly rejected by SAFE_ARGS_REGEX');
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 109: getExecCommand with ../ path traversal in binary — SAFE_NAME_REGEX allows it ──
|
|
console.log('\nRound 109: getExecCommand (path traversal in binary — SAFE_NAME_REGEX permits ../ in binary name):');
|
|
if (test('getExecCommand accepts ../../../etc/passwd as binary because SAFE_NAME_REGEX allows ../', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
// SAFE_NAME_REGEX = /^[@a-zA-Z0-9_.\/-]+$/ individually allows . and /
|
|
const cmd = pm.getExecCommand('../../../etc/passwd');
|
|
assert.strictEqual(cmd, 'npx ../../../etc/passwd',
|
|
'Path traversal in binary passes SAFE_NAME_REGEX because . and / are individually allowed');
|
|
// Also verify scoped path traversal
|
|
const cmd2 = pm.getExecCommand('@scope/../../evil');
|
|
assert.strictEqual(cmd2, 'npx @scope/../../evil',
|
|
'Scoped path traversal also passes the regex');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 108: getRunCommand with path traversal — SAFE_NAME_REGEX allows ../ sequences ──
|
|
console.log('\nRound 108: getRunCommand (path traversal — SAFE_NAME_REGEX permits ../ via allowed / and . chars):');
|
|
if (test('getRunCommand accepts @scope/../../evil because SAFE_NAME_REGEX allows ../', () => {
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
// SAFE_NAME_REGEX = /^[@a-zA-Z0-9_.\/-]+$/ allows each char individually,
|
|
// so '../' passes despite being a path traversal sequence
|
|
const cmd = pm.getRunCommand('@scope/../../evil');
|
|
assert.strictEqual(cmd, 'npm run @scope/../../evil',
|
|
'Path traversal passes SAFE_NAME_REGEX because / and . are individually allowed');
|
|
// Also verify plain ../ passes
|
|
const cmd2 = pm.getRunCommand('../../../etc/passwd');
|
|
assert.strictEqual(cmd2, 'npm run ../../../etc/passwd',
|
|
'Bare ../ traversal also passes the regex');
|
|
} finally {
|
|
if (originalEnv !== undefined) {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
} else {
|
|
delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// ── Round 111: getExecCommand with newline in args — SAFE_ARGS_REGEX \s includes \n ──
|
|
console.log('\nRound 111: getExecCommand (newline in args — SAFE_ARGS_REGEX \\s matches \\n):');
|
|
if (test('getExecCommand accepts newline in args because SAFE_ARGS_REGEX \\s includes \\n', () => {
|
|
// SAFE_ARGS_REGEX = /^[@a-zA-Z0-9\s_.\/:=,'"*+-]+$/
|
|
// \s matches [\t\n\v\f\r ] — includes newline!
|
|
// This means "file.js\nmalicious" passes the regex.
|
|
const originalEnv = process.env.CLAUDE_PACKAGE_MANAGER;
|
|
try {
|
|
process.env.CLAUDE_PACKAGE_MANAGER = 'npm';
|
|
// Newline in args should pass SAFE_ARGS_REGEX because \s matches \n
|
|
const cmd = pm.getExecCommand('prettier', 'file.js\necho injected');
|
|
assert.strictEqual(cmd, 'npx prettier file.js\necho injected',
|
|
'Newline passes SAFE_ARGS_REGEX (\\s includes \\n) — potential command injection vector');
|
|
// Tab also passes
|
|
const cmd2 = pm.getExecCommand('eslint', 'file.js\t--fix');
|
|
assert.strictEqual(cmd2, 'npx eslint file.js\t--fix',
|
|
'Tab also passes SAFE_ARGS_REGEX via \\s');
|
|
// Carriage return also passes
|
|
const cmd3 = pm.getExecCommand('tsc', 'src\r--strict');
|
|
assert.strictEqual(cmd3, 'npx tsc src\r--strict',
|
|
'Carriage return passes via \\s');
|
|
} finally {
|
|
if (originalEnv !== undefined) process.env.CLAUDE_PACKAGE_MANAGER = originalEnv;
|
|
else delete process.env.CLAUDE_PACKAGE_MANAGER;
|
|
}
|
|
})) passed++; else failed++;
|
|
|
|
// Summary
|
|
console.log('\n=== Test Results ===');
|
|
console.log(`Passed: ${passed}`);
|
|
console.log(`Failed: ${failed}`);
|
|
console.log(`Total: ${passed + failed}\n`);
|
|
|
|
process.exit(failed > 0 ? 1 : 0);
|
|
}
|
|
|
|
runTests();
|