zsp/everything-claude-code
1
0
Fork 0
mirror of https://github.com/affaan-m/everything-claude-code.git synced 2026-06-15 04:31:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(skills): address nitpick comments on frontend-a11y

Browse Source
This commit is contained in:
hjkim0905
2026-05-25 00:25:22 +09:00
parent cd52c3b7f2
commit 95d58fc2dd
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
skills/frontend-a11y/SKILL.md
+10 -2
View File
@@ -282,7 +282,15 @@ export function Dropdown({ options, onSelect }: { options: string[]; onSelect: (
}; };
return ( return (
<div role="combobox" aria-expanded={isOpen} aria-haspopup="listbox" aria-controls={listId} tabIndex={0} onKeyDown={handleKeyDown} onClick={() => setIsOpen(prev => !prev)}> <div
role="combobox"
aria-expanded={isOpen}
aria-haspopup="listbox"
aria-controls={listId}
tabIndex={0}
onKeyDown={handleKeyDown}
onClick={() => setIsOpen(prev => !prev)}
>
<span>{options[activeIndex]}</span> <span>{options[activeIndex]}</span>
{isOpen && ( {isOpen && (
<ul id={listId} role="listbox"> <ul id={listId} role="listbox">
@@ -427,7 +435,7 @@ Before submitting any interactive component for review:
- [ ] No `onClick` on `<div>` or `<span>` without `role`, `tabIndex`, and `onKeyDown` - [ ] No `onClick` on `<div>` or `<span>` without `role`, `tabIndex`, and `onKeyDown`
- [ ] Icon-only buttons have `aria-label` - [ ] Icon-only buttons have `aria-label`
- [ ] Decorative images use `alt=""` and `aria-hidden="true"` - [ ] Decorative images use `alt=""` and `aria-hidden="true"`
- [ ] Modals trap focus and restore it on close - [ ] Modals restore focus on close (for full focus trapping with Tab/Shift+Tab cycling, use a library like `focus-trap-react`)
- [ ] Dynamic content updates use `aria-live` - [ ] Dynamic content updates use `aria-live`
- [ ] `prefers-reduced-motion` is respected for animations - [ ] `prefers-reduced-motion` is respected for animations