mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-03-30 21:53:28 +08:00
perf(hooks): reduce PowerShell spawns from 3 to 1 per notification
Merge findPowerShell version check and isBurntToastAvailable check into a single notifyWindows call. Now just tries to send directly; if it fails, tries next PowerShell path. Version field was unused. Net effect: up to 3 spawns reduced to 1 in the happy path.
This commit is contained in:
@@ -35,8 +35,7 @@ if (process.platform === 'linux') {
|
||||
|
||||
/**
|
||||
* Find available PowerShell executable on WSL.
|
||||
* Checks PowerShell 7 first, then falls back to Windows PowerShell.
|
||||
* Returns { path, version } or null if none available.
|
||||
* Returns first accessible path, or null if none found.
|
||||
*/
|
||||
function findPowerShell() {
|
||||
if (!isWSL) return null;
|
||||
@@ -50,11 +49,10 @@ function findPowerShell() {
|
||||
|
||||
for (const path of candidates) {
|
||||
try {
|
||||
const result = spawnSync(path, ['-Command', '$PSVersionTable.PSVersion.Major'],
|
||||
{ stdio: ['ignore', 'pipe', 'ignore'], timeout: 3000 });
|
||||
const result = spawnSync(path, ['-Command', 'exit 0'],
|
||||
{ stdio: ['ignore', 'pipe', 'ignore'], timeout: 1000 });
|
||||
if (result.status === 0) {
|
||||
const version = parseInt(result.stdout.toString().trim(), 10);
|
||||
return { path, version };
|
||||
return path;
|
||||
}
|
||||
} catch {
|
||||
// continue
|
||||
@@ -64,17 +62,16 @@ function findPowerShell() {
|
||||
}
|
||||
|
||||
/**
|
||||
* Check if BurntToast module is available on the given PowerShell path.
|
||||
* Send a Windows Toast notification via PowerShell BurntToast.
|
||||
* Returns true on success, false on failure.
|
||||
*/
|
||||
function isBurntToastAvailable(pwshPath) {
|
||||
try {
|
||||
const result = spawnSync(pwshPath,
|
||||
['-Command', 'Import-Module BurntToast -ErrorAction Stop; $true'],
|
||||
{ stdio: ['ignore', 'pipe', 'ignore'], timeout: 5000 });
|
||||
return result.status === 0;
|
||||
} catch {
|
||||
return false;
|
||||
}
|
||||
function notifyWindows(pwshPath, title, body) {
|
||||
const safeBody = body.replace(/'/g, "''");
|
||||
const safeTitle = title.replace(/'/g, "''");
|
||||
const command = `Import-Module BurntToast; New-BurntToastNotification -Text '${safeTitle}', '${safeBody}'`;
|
||||
const result = spawnSync(pwshPath, ['-Command', command],
|
||||
{ stdio: ['ignore', 'pipe', 'pipe'], timeout: 5000 });
|
||||
return result.status === 0;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -136,14 +133,12 @@ function run(raw) {
|
||||
if (isMacOS) {
|
||||
notifyMacOS(TITLE, summary);
|
||||
} else if (isWSL) {
|
||||
// WSL: try PowerShell 7 first, then Windows PowerShell
|
||||
const ps = findPowerShell();
|
||||
if (ps && isBurntToastAvailable(ps.path)) {
|
||||
notifyWindows(ps.path, TITLE, summary);
|
||||
if (ps && notifyWindows(ps, TITLE, summary)) {
|
||||
// notification sent successfully
|
||||
} else if (ps) {
|
||||
// PowerShell exists but no BurntToast module
|
||||
log('[DesktopNotify] Tip: Install BurntToast module to enable notifications:');
|
||||
log(`[DesktopNotify] "${ps.path}" -Command "Install-Module -Name BurntToast -Scope CurrentUser"`);
|
||||
// PowerShell found but BurntToast not available
|
||||
log('[DesktopNotify] Tip: Install BurntToast module to enable notifications');
|
||||
} else {
|
||||
// No PowerShell found
|
||||
log('[DesktopNotify] Tip: Install BurntToast module in PowerShell for notifications');
|
||||
|
||||
Reference in New Issue
Block a user