fix: address PR review findings for quarkus skills

- Add missing objectMapper field to EventService example (quarkus-patterns)
- Fix eventService.validate() → documentValidator.validate() API mismatch (quarkus-tdd)
- Add DocumentValidator mock declaration in Camel route test (quarkus-tdd)
- Update .opencode java-reviewer.txt to mention Quarkus alongside Spring Boot
This commit is contained in:
AlexisLeDain
2026-04-08 22:08:38 +02:00
parent 63934f382a
commit 9b9f71c2e5
3 changed files with 7 additions and 3 deletions
+1 -1
View File
@@ -1,4 +1,4 @@
You are a senior Java engineer ensuring high standards of idiomatic Java and Spring Boot best practices. You are a senior Java engineer ensuring high standards of idiomatic Java, Spring Boot, and Quarkus best practices.
When invoked: When invoked:
1. Run `git diff -- '*.java'` to see recent Java file changes 1. Run `git diff -- '*.java'` to see recent Java file changes
+1
View File
@@ -156,6 +156,7 @@ public class ProcessingService {
@RequiredArgsConstructor @RequiredArgsConstructor
public class EventService { public class EventService {
private final EventRepository eventRepository; private final EventRepository eventRepository;
private final ObjectMapper objectMapper;
public void createSuccessEvent(Object payload, String eventType) { public void createSuccessEvent(Object payload, String eventType) {
Event event = new Event(); Event event = new Event();
+5 -2
View File
@@ -265,6 +265,9 @@ class BusinessRulesRouteTest {
@InjectMock @InjectMock
EventService eventService; EventService eventService;
@InjectMock
DocumentValidator documentValidator;
private BusinessRulesPayload testPayload; private BusinessRulesPayload testPayload;
@BeforeEach @BeforeEach
@@ -371,8 +374,8 @@ class BusinessRulesRouteTest {
}); });
camelContext.getRouteController().startRoute("document-processing"); camelContext.getRouteController().startRoute("document-processing");
// Mock validator to throw exception // Mock validator bean to throw exception
when(eventService.validate(any())).thenThrow(new ValidationException("Invalid document")); when(documentValidator.validate(any())).thenThrow(new ValidationException("Invalid document"));
// ACT // ACT
producerTemplate.sendBody("direct:process-document", testPayload); producerTemplate.sendBody("direct:process-document", testPayload);