mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-03-30 21:53:28 +08:00
177dd36e23
* fix(hooks): fix shell splitter redirection/escape bugs, extract shared module - Fix single & incorrectly splitting redirection operators (&>, >&, 2>&1) - Fix escaped quotes (\", \') not being handled inside quoted strings - Extract splitShellSegments into shared scripts/lib/shell-split.js to eliminate duplication between hooks.json, before-shell-execution.js, and pre-bash-dev-server-block.js - Add comprehensive tests for shell splitting edge cases * fix(hooks): handle backslash escapes outside quotes in shell splitter Escaped operators like \&& and \; outside quotes were still being treated as separators. Add escape handling for unquoted context.
115 lines
3.8 KiB
JavaScript
115 lines
3.8 KiB
JavaScript
'use strict';
|
|
const assert = require('assert');
|
|
const { splitShellSegments } = require('../../scripts/lib/shell-split');
|
|
|
|
console.log('=== Testing shell-split.js ===\n');
|
|
|
|
let passed = 0;
|
|
let failed = 0;
|
|
|
|
function test(desc, fn) {
|
|
try {
|
|
fn();
|
|
console.log(` ✓ ${desc}`);
|
|
passed++;
|
|
} catch (e) {
|
|
console.log(` ✗ ${desc}: ${e.message}`);
|
|
failed++;
|
|
}
|
|
}
|
|
|
|
// Basic operators
|
|
console.log('Basic operators:');
|
|
test('&& splits into two segments', () => {
|
|
assert.deepStrictEqual(splitShellSegments('echo hi && echo bye'), ['echo hi', 'echo bye']);
|
|
});
|
|
test('|| splits into two segments', () => {
|
|
assert.deepStrictEqual(splitShellSegments('echo hi || echo bye'), ['echo hi', 'echo bye']);
|
|
});
|
|
test('; splits into two segments', () => {
|
|
assert.deepStrictEqual(splitShellSegments('echo hi; echo bye'), ['echo hi', 'echo bye']);
|
|
});
|
|
test('single & splits (background)', () => {
|
|
assert.deepStrictEqual(splitShellSegments('sleep 1 & echo hi'), ['sleep 1', 'echo hi']);
|
|
});
|
|
|
|
// Redirection operators should NOT split
|
|
console.log('\nRedirection operators (should NOT split):');
|
|
test('2>&1 stays as one segment', () => {
|
|
const segs = splitShellSegments('cmd 2>&1 | grep error');
|
|
assert.strictEqual(segs.length, 1);
|
|
});
|
|
test('&> stays as one segment', () => {
|
|
const segs = splitShellSegments('cmd &> /dev/null');
|
|
assert.strictEqual(segs.length, 1);
|
|
});
|
|
test('>& stays as one segment', () => {
|
|
const segs = splitShellSegments('cmd >& /dev/null');
|
|
assert.strictEqual(segs.length, 1);
|
|
});
|
|
|
|
// Quoting
|
|
console.log('\nQuoting:');
|
|
test('double-quoted && not split', () => {
|
|
const segs = splitShellSegments('tmux new -d "cd /app && echo hi"');
|
|
assert.strictEqual(segs.length, 1);
|
|
});
|
|
test('single-quoted && not split', () => {
|
|
const segs = splitShellSegments("tmux new -d 'cd /app && echo hi'");
|
|
assert.strictEqual(segs.length, 1);
|
|
});
|
|
test('double-quoted ; not split', () => {
|
|
const segs = splitShellSegments('echo "hello; world"');
|
|
assert.strictEqual(segs.length, 1);
|
|
});
|
|
|
|
// Escaped quotes
|
|
console.log('\nEscaped quotes:');
|
|
test('escaped double quote inside double quotes', () => {
|
|
const segs = splitShellSegments('echo "hello \\"world\\"" && echo bye');
|
|
assert.strictEqual(segs.length, 2);
|
|
});
|
|
test('escaped single quote inside single quotes', () => {
|
|
const segs = splitShellSegments("echo 'hello \\'world\\'' && echo bye");
|
|
assert.strictEqual(segs.length, 2);
|
|
});
|
|
|
|
// Escaped operators outside quotes
|
|
console.log('\nEscaped operators outside quotes:');
|
|
test('escaped && outside quotes not split', () => {
|
|
const segs = splitShellSegments('tmux new-session -d bash -lc cd /app \\&\\& npm run dev');
|
|
assert.strictEqual(segs.length, 1);
|
|
});
|
|
test('escaped ; outside quotes not split', () => {
|
|
const segs = splitShellSegments('echo hello \\; echo bye');
|
|
assert.strictEqual(segs.length, 1);
|
|
});
|
|
|
|
// Complex real-world cases
|
|
console.log('\nReal-world cases:');
|
|
test('tmux new-session with quoted compound command', () => {
|
|
const segs = splitShellSegments('tmux new-session -d -s dev "cd /app && npm run dev"');
|
|
assert.strictEqual(segs.length, 1);
|
|
assert.ok(segs[0].includes('tmux'));
|
|
assert.ok(segs[0].includes('npm run dev'));
|
|
});
|
|
test('chained: tmux ls then bare dev', () => {
|
|
const segs = splitShellSegments('tmux ls; npm run dev');
|
|
assert.strictEqual(segs.length, 2);
|
|
assert.strictEqual(segs[1], 'npm run dev');
|
|
});
|
|
test('background dev server', () => {
|
|
const segs = splitShellSegments('npm run dev & echo started');
|
|
assert.strictEqual(segs.length, 2);
|
|
assert.strictEqual(segs[0], 'npm run dev');
|
|
});
|
|
test('empty string returns empty array', () => {
|
|
assert.deepStrictEqual(splitShellSegments(''), []);
|
|
});
|
|
test('single command no operators', () => {
|
|
assert.deepStrictEqual(splitShellSegments('npm run dev'), ['npm run dev']);
|
|
});
|
|
|
|
console.log(`\n=== Results: ${passed} passed, ${failed} failed ===`);
|
|
if (failed > 0) process.exit(1);
|