mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-05-18 14:53:05 +08:00
`readSessionCost` read only the trailing 8 KiB of
`~/.claude/metrics/costs.jsonl` to "avoid scanning entire file".
That ceiling is the opposite-sign sibling of the double-count bug
fixed in the previous commit: once a session's most recent
cumulative row gets pushed past the 8 KiB window by newer rows
from other sessions, the bridge silently reports `totalCost: 0`,
`totalIn: 0`, `totalOut: 0` for that session — same false signal
to `ecc-context-monitor.js`, same wrong number injected into the
live model turn as `additionalContext`.
`cost-tracker.js` has no rotation policy, so on any non-trivial
workstation costs.jsonl grows past 8 KiB within minutes of normal
use. For users who keep multiple concurrent sessions, this means
the second-and-later sessions silently report zero almost
immediately.
Reproduced before this commit:
$ HOME=/tmp/eccc node -e '
const fs = require("fs");
const m = require("./scripts/hooks/ecc-metrics-bridge.js");
// S1 row at file start, then 200 rows of OTHER-session noise (~16 KiB).
// S1 is the row we want, but it sits past the 8 KiB tail.
const s1 = `{"session_id":"S1","estimated_cost_usd":0.5,"input_tokens":500,"output_tokens":250}`;
const other = `{"session_id":"OTHER","estimated_cost_usd":1,"input_tokens":100,"output_tokens":50}`;
fs.mkdirSync("/tmp/eccc/.claude/metrics", { recursive: true });
fs.writeFileSync("/tmp/eccc/.claude/metrics/costs.jsonl",
[s1, ...Array(200).fill(other)].join("\\n") + "\\n");
console.log(JSON.stringify(m.readSessionCost("S1")));'
{"totalCost":0,"totalIn":0,"totalOut":0}
Expected: `{"totalCost":0.5, "totalIn":500, "totalOut":250}` (the
S1 row that exists in the file).
Actual: zero — the row is past the 8 KiB tail.
Fix: drop the `fs.openSync` + bounded `fs.readSync` + position
arithmetic in favour of `fs.readFileSync(costsPath, 'utf8')` and
iterate every line. Each row is ~150 bytes; even 100k rows is
~15 MB and a single sync read on PreToolUse is in the low ms.
If file rotation lands in `cost-tracker.js` later, this scan
becomes proportionally cheaper.
After this commit the reproduction above returns
`{"totalCost":0.5, "totalIn":500, "totalOut":250}`.
Regression test in `tests/hooks/ecc-metrics-bridge.test.js`:
`readSessionCost finds session row beyond the old 8 KiB tail
boundary`. The test asserts the costs.jsonl fixture is > 8 KiB
before reading so any reintroduction of a bounded tail would
re-fail the test (i.e. the assertion is the contract, not the
specific number 8192).
Together with the previous commit, both directions of the
metrics-bridge cost-reporting bug are closed.
300 lines
10 KiB
JavaScript
300 lines
10 KiB
JavaScript
/**
|
|
* Tests for scripts/hooks/ecc-metrics-bridge.js
|
|
*
|
|
* Run with: node tests/hooks/ecc-metrics-bridge.test.js
|
|
*/
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const os = require('os');
|
|
const path = require('path');
|
|
|
|
const { run, hashToolCall, extractFilePaths, readSessionCost } = require('../../scripts/hooks/ecc-metrics-bridge');
|
|
|
|
// Test helper
|
|
function test(name, fn) {
|
|
try {
|
|
fn();
|
|
console.log(` \u2713 ${name}`);
|
|
return true;
|
|
} catch (err) {
|
|
console.log(` \u2717 ${name}`);
|
|
console.log(` Error: ${err.message}`);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function makeTempHome() {
|
|
return fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-metrics-bridge-test-'));
|
|
}
|
|
|
|
function runTests() {
|
|
console.log('\n=== Testing ecc-metrics-bridge.js ===\n');
|
|
|
|
let passed = 0;
|
|
let failed = 0;
|
|
|
|
// hashToolCall tests
|
|
console.log('hashToolCall:');
|
|
|
|
if (
|
|
test('returns 8-char hex string', () => {
|
|
const hash = hashToolCall('Bash', { command: 'ls' });
|
|
assert.strictEqual(hash.length, 8);
|
|
assert.ok(/^[0-9a-f]{8}$/.test(hash), `Expected hex, got: ${hash}`);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('different Bash commands produce different hashes', () => {
|
|
const h1 = hashToolCall('Bash', { command: 'ls' });
|
|
const h2 = hashToolCall('Bash', { command: 'pwd' });
|
|
assert.notStrictEqual(h1, h2);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('different Edit file_paths produce different hashes', () => {
|
|
const h1 = hashToolCall('Edit', { file_path: 'a.js' });
|
|
const h2 = hashToolCall('Edit', { file_path: 'b.js' });
|
|
assert.notStrictEqual(h1, h2);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('same inputs produce same hash (deterministic)', () => {
|
|
const h1 = hashToolCall('Write', { file_path: 'x.txt' });
|
|
const h2 = hashToolCall('Write', { file_path: 'x.txt' });
|
|
assert.strictEqual(h1, h2);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('non-file tools hash by stable input to avoid false loop collisions', () => {
|
|
const h1 = hashToolCall('Glob', { pattern: '**/*.js', path: '/repo/a' });
|
|
const h2 = hashToolCall('Glob', { pattern: '**/*.md', path: '/repo/a' });
|
|
const h3 = hashToolCall('Glob', { path: '/repo/a', pattern: '**/*.js' });
|
|
assert.notStrictEqual(h1, h2);
|
|
assert.strictEqual(h1, h3);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
// extractFilePaths tests
|
|
console.log('\nextractFilePaths:');
|
|
|
|
if (
|
|
test('Edit with file_path returns [file_path]', () => {
|
|
const paths = extractFilePaths('Edit', { file_path: 'a.js' });
|
|
assert.deepStrictEqual(paths, ['a.js']);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('MultiEdit with edits array returns all file_paths', () => {
|
|
const paths = extractFilePaths('MultiEdit', {
|
|
edits: [{ file_path: 'a.js' }, { file_path: 'b.js' }]
|
|
});
|
|
assert.deepStrictEqual(paths, ['a.js', 'b.js']);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('Bash with command returns empty array', () => {
|
|
const paths = extractFilePaths('Bash', { command: 'ls' });
|
|
assert.deepStrictEqual(paths, []);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('null toolInput returns empty array', () => {
|
|
const paths = extractFilePaths('Edit', null);
|
|
assert.deepStrictEqual(paths, []);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
// readSessionCost tests
|
|
console.log('\nreadSessionCost:');
|
|
|
|
if (
|
|
test('nonexistent session returns object with numeric fields', () => {
|
|
const result = readSessionCost('nonexistent-session-cost-test-xyz-999');
|
|
assert.strictEqual(typeof result.totalCost, 'number');
|
|
assert.strictEqual(typeof result.totalIn, 'number');
|
|
assert.strictEqual(typeof result.totalOut, 'number');
|
|
assert.ok(result.totalCost >= 0, 'totalCost should be non-negative');
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('readSessionCost returns the LAST cumulative row, not the sum (cost-tracker contract)', () => {
|
|
// cost-tracker.js writes one row per Stop event; each row is already
|
|
// a cumulative session total ("To get per-session cost, take the
|
|
// last row per session_id."). Summing across rows over-counts:
|
|
// 0.01 + 0.02 + 0.03 = 0.06, but the correct answer is 0.03.
|
|
const tmpHome = makeTempHome();
|
|
const originalHome = process.env.HOME;
|
|
const originalUserProfile = process.env.USERPROFILE;
|
|
try {
|
|
process.env.HOME = tmpHome;
|
|
process.env.USERPROFILE = tmpHome;
|
|
const metricsDir = path.join(tmpHome, '.claude', 'metrics');
|
|
fs.mkdirSync(metricsDir, { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(metricsDir, 'costs.jsonl'),
|
|
[
|
|
JSON.stringify({ session_id: 'S1', estimated_cost_usd: 0.01, input_tokens: 333, output_tokens: 166 }),
|
|
JSON.stringify({ session_id: 'S1', estimated_cost_usd: 0.02, input_tokens: 666, output_tokens: 333 }),
|
|
JSON.stringify({ session_id: 'S1', estimated_cost_usd: 0.03, input_tokens: 1000, output_tokens: 500 })
|
|
].join('\n') + '\n',
|
|
'utf8'
|
|
);
|
|
const result = readSessionCost('S1');
|
|
assert.strictEqual(result.totalCost, 0.03, `expected last-row 0.03, got ${result.totalCost} (was the bug: 0.06)`);
|
|
assert.strictEqual(result.totalIn, 1000);
|
|
assert.strictEqual(result.totalOut, 500);
|
|
} finally {
|
|
if (originalHome === undefined) delete process.env.HOME;
|
|
else process.env.HOME = originalHome;
|
|
if (originalUserProfile === undefined) delete process.env.USERPROFILE;
|
|
else process.env.USERPROFILE = originalUserProfile;
|
|
fs.rmSync(tmpHome, { recursive: true, force: true });
|
|
}
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('readSessionCost finds session row beyond the old 8 KiB tail boundary', () => {
|
|
// The previous implementation read only the trailing 8 KiB of
|
|
// costs.jsonl. A long-running deployment where the target session's
|
|
// most recent cumulative row sat further back than that — e.g.
|
|
// pushed past by many rows from OTHER sessions — silently saw
|
|
// cost=0. This test wedges the S1 row at the file start, fills
|
|
// ~16 KiB of OTHER-session noise after it, and asserts the S1 row
|
|
// is still found.
|
|
const tmpHome = makeTempHome();
|
|
const originalHome = process.env.HOME;
|
|
const originalUserProfile = process.env.USERPROFILE;
|
|
try {
|
|
process.env.HOME = tmpHome;
|
|
process.env.USERPROFILE = tmpHome;
|
|
const metricsDir = path.join(tmpHome, '.claude', 'metrics');
|
|
fs.mkdirSync(metricsDir, { recursive: true });
|
|
const otherRow = JSON.stringify({ session_id: 'OTHER', estimated_cost_usd: 1, input_tokens: 100, output_tokens: 50 });
|
|
const s1Row = JSON.stringify({ session_id: 'S1', estimated_cost_usd: 0.5, input_tokens: 500, output_tokens: 250 });
|
|
const rows = [s1Row, ...Array(200).fill(otherRow)];
|
|
fs.writeFileSync(path.join(metricsDir, 'costs.jsonl'), rows.join('\n') + '\n', 'utf8');
|
|
// Confirm we're actually past the old 8 KiB ceiling so the test
|
|
// would have failed under the previous implementation.
|
|
const size = fs.statSync(path.join(metricsDir, 'costs.jsonl')).size;
|
|
assert.ok(size > 8192, `setup: expected costs.jsonl > 8 KiB, got ${size} bytes`);
|
|
const result = readSessionCost('S1');
|
|
assert.strictEqual(result.totalCost, 0.5);
|
|
assert.strictEqual(result.totalIn, 500);
|
|
assert.strictEqual(result.totalOut, 250);
|
|
} finally {
|
|
if (originalHome === undefined) delete process.env.HOME;
|
|
else process.env.HOME = originalHome;
|
|
if (originalUserProfile === undefined) delete process.env.USERPROFILE;
|
|
else process.env.USERPROFILE = originalUserProfile;
|
|
fs.rmSync(tmpHome, { recursive: true, force: true });
|
|
}
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('readSessionCost does not include unrelated default-session rows', () => {
|
|
const tmpHome = makeTempHome();
|
|
const originalHome = process.env.HOME;
|
|
const originalUserProfile = process.env.USERPROFILE;
|
|
try {
|
|
process.env.HOME = tmpHome;
|
|
process.env.USERPROFILE = tmpHome;
|
|
const metricsDir = path.join(tmpHome, '.claude', 'metrics');
|
|
fs.mkdirSync(metricsDir, { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(metricsDir, 'costs.jsonl'),
|
|
[
|
|
JSON.stringify({ session_id: 'default', estimated_cost_usd: 50, input_tokens: 1000, output_tokens: 2000 }),
|
|
JSON.stringify({ session_id: 'target-session', estimated_cost_usd: 1.25, input_tokens: 10, output_tokens: 20 })
|
|
].join('\n') + '\n',
|
|
'utf8'
|
|
);
|
|
const result = readSessionCost('target-session');
|
|
assert.strictEqual(result.totalCost, 1.25);
|
|
assert.strictEqual(result.totalIn, 10);
|
|
assert.strictEqual(result.totalOut, 20);
|
|
} finally {
|
|
if (originalHome === undefined) delete process.env.HOME;
|
|
else process.env.HOME = originalHome;
|
|
if (originalUserProfile === undefined) delete process.env.USERPROFILE;
|
|
else process.env.USERPROFILE = originalUserProfile;
|
|
fs.rmSync(tmpHome, { recursive: true, force: true });
|
|
}
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
// run tests
|
|
console.log('\nrun:');
|
|
|
|
if (
|
|
test('empty input returns empty input without crashing', () => {
|
|
const result = run('');
|
|
assert.strictEqual(result, '');
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('whitespace-only input returns input unchanged', () => {
|
|
const result = run(' ');
|
|
assert.strictEqual(result, ' ');
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
if (
|
|
test('input without session_id returns input unchanged', () => {
|
|
const input = JSON.stringify({ tool_name: 'Bash', tool_input: { command: 'ls' } });
|
|
const result = run(input);
|
|
assert.strictEqual(result, input);
|
|
})
|
|
)
|
|
passed++;
|
|
else failed++;
|
|
|
|
// Summary
|
|
console.log(`\nResults: ${passed} passed, ${failed} failed\n`);
|
|
return { passed, failed };
|
|
}
|
|
|
|
const { failed } = runTests();
|
|
process.exit(failed > 0 ? 1 : 0);
|