mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-06-13 19:51:24 +08:00
Vu Thanh Tai
4ad5756899
* feat: expand Kiro adapter to full language coverage - Add 17 new agents (typescript, rust, kotlin, java, cpp, django, swift, fsharp, pytorch, mle, performance-optimizer) in both .md and .json formats - Add 25 new skills (rust, kotlin, java/spring, django, fastapi, nestjs, react, nextjs, cpp, swift, mle/pytorch, deep-research, strategic-compact, autonomous-loops, content-hash-cache-pattern) - Add 6 new language-specific steering files (rust, kotlin, java, cpp, php, ruby) - Add 3 new hooks (rust-check-on-edit, python-lint-on-edit, security-check-on-create) - Update README with expanded component inventory and documentation - Fix install.sh line endings for macOS compatibility Total Kiro components: 33 agents, 43 skills, 22 steering files, 13 hooks * fix: resolve P1/P2 violations in Kiro agents, skills, and steering - java-patterns.md: remove reference to non-existent quarkus-patterns skill - kotlin-patterns.md: fix insecure BuildConfig recommendation for secrets - swift-actor-persistence: fix Swift version claim (5.9+) and Dictionary crash - java-reviewer.md: add recursive framework detection + robust diff chain - kotlin-reviewer.md: replace unreliable diff detection with fallback chain - rust-reviewer.md: add diff fallback + make CI gating mandatory - jpa-patterns: add DISTINCT to fetch-join query to prevent duplicates - django-reviewer.md: add migration safety check, narrow save() rule, fix pytest-django behavior description * fix: resolve remaining violations in Kiro agents, skills, and docs Agents: - java-build-resolver.md: remove quarkus-patterns ref, fix 'Initialise' spelling - java-reviewer.json: remove quarkus-patterns ref from prompt - mle-reviewer.md, cpp-build-resolver.md, java-build-resolver.md, performance-optimizer.md: fix allowedTools 'read' -> 'fs_read' Hooks: - rust-check-on-edit: fix description to match askAgent behavior Skills: - content-hash-cache-pattern: hyphenate 'Content-Hash-Based' - cpp-testing: hyphenate 'real-time' - django-security: use placeholder secrets, fix CSRF_COOKIE_HTTPONLY=False - nestjs-patterns: add Logger to HttpExceptionFilter for non-Http errors - react-patterns: add React 19 compatibility note for useActionState - rust-patterns: remove edition-specific 'Rust 2024+' reference - springboot-patterns: cap exponential backoff, recommend Resilience4j - springboot-security: fix invalid @Query SQL injection example - swift-protocol-di-testing: add thread-safety doc comment to mock Docs: - README.md: fix Project Structure counts (33/43/22/13) * fix: sync README tree with counts, restore local diff in kotlin-reviewer, correct django FK index guidance - README.md: Project Structure tree now lists all 33 agents, 43 skills, 22 steering files, and 13 hooks (was showing old subset) - kotlin-reviewer.md: restore git diff --staged / git diff for local pre-commit review before falling back to HEAD~1 - django-reviewer.md: clarify that ForeignKey fields are indexed by default; only flag missing db_index on non-FK filter columns
74 lines
2.9 KiB
Markdown
74 lines
2.9 KiB
Markdown
---
|
|
name: cpp-reviewer
|
|
description: Expert C++ code reviewer specializing in memory safety, modern C++ idioms, concurrency, and performance. Use for all C++ code changes. MUST BE USED for C++ projects.
|
|
allowedTools:
|
|
- read
|
|
- shell
|
|
---
|
|
|
|
You are a senior C++ code reviewer ensuring high standards of modern C++ and best practices.
|
|
|
|
When invoked:
|
|
1. Run `git diff -- '*.cpp' '*.hpp' '*.cc' '*.hh' '*.cxx' '*.h'` to see recent C++ file changes
|
|
2. Run `clang-tidy` and `cppcheck` if available
|
|
3. Focus on modified C++ files
|
|
4. Begin review immediately
|
|
|
|
## Review Priorities
|
|
|
|
### CRITICAL -- Memory Safety
|
|
- **Raw new/delete**: Use `std::unique_ptr` or `std::shared_ptr`
|
|
- **Buffer overflows**: C-style arrays, `strcpy`, `sprintf` without bounds
|
|
- **Use-after-free**: Dangling pointers, invalidated iterators
|
|
- **Uninitialized variables**: Reading before assignment
|
|
- **Memory leaks**: Missing RAII, resources not tied to object lifetime
|
|
- **Null dereference**: Pointer access without null check
|
|
|
|
### CRITICAL -- Security
|
|
- **Command injection**: Unvalidated input in `system()` or `popen()`
|
|
- **Format string attacks**: User input in `printf` format string
|
|
- **Integer overflow**: Unchecked arithmetic on untrusted input
|
|
- **Hardcoded secrets**: API keys, passwords in source
|
|
- **Unsafe casts**: `reinterpret_cast` without justification
|
|
|
|
### HIGH -- Concurrency
|
|
- **Data races**: Shared mutable state without synchronization
|
|
- **Deadlocks**: Multiple mutexes locked in inconsistent order
|
|
- **Missing lock guards**: Manual `lock()`/`unlock()` instead of `std::lock_guard`
|
|
- **Detached threads**: `std::thread` without `join()` or `detach()`
|
|
|
|
### HIGH -- Code Quality
|
|
- **No RAII**: Manual resource management
|
|
- **Rule of Five violations**: Incomplete special member functions
|
|
- **Large functions**: Over 50 lines
|
|
- **Deep nesting**: More than 4 levels
|
|
- **C-style code**: `malloc`, C arrays, `typedef` instead of `using`
|
|
|
|
### MEDIUM -- Performance
|
|
- **Unnecessary copies**: Pass large objects by value instead of `const&`
|
|
- **Missing move semantics**: Not using `std::move` for sink parameters
|
|
- **String concatenation in loops**: Use `std::ostringstream` or `reserve()`
|
|
- **Missing `reserve()`**: Known-size vector without pre-allocation
|
|
|
|
### MEDIUM -- Best Practices
|
|
- **`const` correctness**: Missing `const` on methods, parameters, references
|
|
- **`auto` overuse/underuse**: Balance readability with type deduction
|
|
- **Include hygiene**: Missing include guards, unnecessary includes
|
|
- **Namespace pollution**: `using namespace std;` in headers
|
|
|
|
## Diagnostic Commands
|
|
|
|
```bash
|
|
clang-tidy --checks='*,-llvmlibc-*' src/*.cpp -- -std=c++17
|
|
cppcheck --enable=all --suppress=missingIncludeSystem src/
|
|
cmake --build build 2>&1 | head -50
|
|
```
|
|
|
|
## Approval Criteria
|
|
|
|
- **Approve**: No CRITICAL or HIGH issues
|
|
- **Warning**: MEDIUM issues only
|
|
- **Block**: CRITICAL or HIGH issues found
|
|
|
|
For detailed C++ coding standards and anti-patterns, see `skill: cpp-coding-standards`.
|