mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-06-14 20:21:23 +08:00
4ad5756899
* feat: expand Kiro adapter to full language coverage - Add 17 new agents (typescript, rust, kotlin, java, cpp, django, swift, fsharp, pytorch, mle, performance-optimizer) in both .md and .json formats - Add 25 new skills (rust, kotlin, java/spring, django, fastapi, nestjs, react, nextjs, cpp, swift, mle/pytorch, deep-research, strategic-compact, autonomous-loops, content-hash-cache-pattern) - Add 6 new language-specific steering files (rust, kotlin, java, cpp, php, ruby) - Add 3 new hooks (rust-check-on-edit, python-lint-on-edit, security-check-on-create) - Update README with expanded component inventory and documentation - Fix install.sh line endings for macOS compatibility Total Kiro components: 33 agents, 43 skills, 22 steering files, 13 hooks * fix: resolve P1/P2 violations in Kiro agents, skills, and steering - java-patterns.md: remove reference to non-existent quarkus-patterns skill - kotlin-patterns.md: fix insecure BuildConfig recommendation for secrets - swift-actor-persistence: fix Swift version claim (5.9+) and Dictionary crash - java-reviewer.md: add recursive framework detection + robust diff chain - kotlin-reviewer.md: replace unreliable diff detection with fallback chain - rust-reviewer.md: add diff fallback + make CI gating mandatory - jpa-patterns: add DISTINCT to fetch-join query to prevent duplicates - django-reviewer.md: add migration safety check, narrow save() rule, fix pytest-django behavior description * fix: resolve remaining violations in Kiro agents, skills, and docs Agents: - java-build-resolver.md: remove quarkus-patterns ref, fix 'Initialise' spelling - java-reviewer.json: remove quarkus-patterns ref from prompt - mle-reviewer.md, cpp-build-resolver.md, java-build-resolver.md, performance-optimizer.md: fix allowedTools 'read' -> 'fs_read' Hooks: - rust-check-on-edit: fix description to match askAgent behavior Skills: - content-hash-cache-pattern: hyphenate 'Content-Hash-Based' - cpp-testing: hyphenate 'real-time' - django-security: use placeholder secrets, fix CSRF_COOKIE_HTTPONLY=False - nestjs-patterns: add Logger to HttpExceptionFilter for non-Http errors - react-patterns: add React 19 compatibility note for useActionState - rust-patterns: remove edition-specific 'Rust 2024+' reference - springboot-patterns: cap exponential backoff, recommend Resilience4j - springboot-security: fix invalid @Query SQL injection example - swift-protocol-di-testing: add thread-safety doc comment to mock Docs: - README.md: fix Project Structure counts (33/43/22/13) * fix: sync README tree with counts, restore local diff in kotlin-reviewer, correct django FK index guidance - README.md: Project Structure tree now lists all 33 agents, 43 skills, 22 steering files, and 13 hooks (was showing old subset) - kotlin-reviewer.md: restore git diff --staged / git diff for local pre-commit review before falling back to HEAD~1 - django-reviewer.md: clarify that ForeignKey fields are indexed by default; only flag missing db_index on non-FK filter columns
139 lines
3.5 KiB
Markdown
139 lines
3.5 KiB
Markdown
---
|
|
inclusion: fileMatch
|
|
fileMatchPattern: "*.kt"
|
|
description: Kotlin-specific patterns, coroutines, Compose, and Android/KMP best practices.
|
|
---
|
|
|
|
# Kotlin Patterns
|
|
|
|
> This file extends the common patterns with Kotlin and Android/KMP specific content.
|
|
|
|
## Immutability & Null Safety
|
|
|
|
- Prefer `val` over `var` — default to `val` and only use `var` when mutation is required
|
|
- Use `data class` for value types; use immutable collections in public APIs
|
|
- Never use `!!` — prefer `?.`, `?:`, `requireNotNull()`, or `checkNotNull()`
|
|
|
|
```kotlin
|
|
// BAD
|
|
val name = user!!.name
|
|
|
|
// GOOD
|
|
val name = user?.name ?: "Unknown"
|
|
```
|
|
|
|
## Sealed Types
|
|
|
|
Use sealed classes/interfaces to model closed state hierarchies:
|
|
|
|
```kotlin
|
|
sealed interface UiState<out T> {
|
|
data object Loading : UiState<Nothing>
|
|
data class Success<T>(val data: T) : UiState<T>
|
|
data class Error(val message: String) : UiState<Nothing>
|
|
}
|
|
```
|
|
|
|
Always use exhaustive `when` with sealed types — no `else` branch.
|
|
|
|
## ViewModel Pattern
|
|
|
|
Single state object, event sink, one-way data flow:
|
|
|
|
```kotlin
|
|
data class ScreenState(
|
|
val items: List<Item> = emptyList(),
|
|
val isLoading: Boolean = false
|
|
)
|
|
|
|
class ScreenViewModel(private val useCase: GetItemsUseCase) : ViewModel() {
|
|
private val _state = MutableStateFlow(ScreenState())
|
|
val state = _state.asStateFlow()
|
|
|
|
fun onEvent(event: ScreenEvent) {
|
|
when (event) {
|
|
is ScreenEvent.Load -> load()
|
|
is ScreenEvent.Delete -> delete(event.id)
|
|
}
|
|
}
|
|
}
|
|
```
|
|
|
|
## UseCase Pattern
|
|
|
|
Single responsibility, `operator fun invoke`:
|
|
|
|
```kotlin
|
|
class GetItemUseCase(private val repository: ItemRepository) {
|
|
suspend operator fun invoke(id: String): Result<Item> {
|
|
return repository.getById(id)
|
|
}
|
|
}
|
|
```
|
|
|
|
## Dependency Injection
|
|
|
|
Prefer constructor injection. Use Koin (KMP) or Hilt (Android-only):
|
|
|
|
```kotlin
|
|
// Koin
|
|
val dataModule = module {
|
|
single<ItemRepository> { ItemRepositoryImpl(get(), get()) }
|
|
factory { GetItemsUseCase(get()) }
|
|
viewModelOf(::ItemListViewModel)
|
|
}
|
|
```
|
|
|
|
## Coroutine Patterns
|
|
|
|
- Use `viewModelScope` in ViewModels, `coroutineScope` for structured child work
|
|
- Use `supervisorScope` when child failures should be independent
|
|
- Never catch `CancellationException` — always rethrow it
|
|
|
|
## expect/actual (KMP)
|
|
|
|
Use for platform-specific implementations:
|
|
|
|
```kotlin
|
|
// commonMain
|
|
expect fun platformName(): String
|
|
|
|
// androidMain
|
|
actual fun platformName(): String = "Android"
|
|
|
|
// iosMain
|
|
actual fun platformName(): String = "iOS"
|
|
```
|
|
|
|
## Security
|
|
|
|
- Never embed secrets in `BuildConfig` or resources — values are extractable from the APK
|
|
- Use `EncryptedSharedPreferences` or Android Keystore (Android), Keychain (iOS), or a server-side proxy for runtime secrets
|
|
- Use parameterized queries for Room/SQLDelight
|
|
- Configure `network_security_config.xml` to block cleartext traffic
|
|
|
|
## Testing
|
|
|
|
- Use `kotlin.test` for multiplatform, JUnit for Android-specific tests
|
|
- Use Turbine for testing Flows and StateFlow
|
|
- Use `runTest` with `kotlinx-coroutines-test` for coroutine testing
|
|
- Prefer hand-written fakes over mocking frameworks
|
|
|
|
```kotlin
|
|
@Test
|
|
fun `loading state emitted then data`() = runTest {
|
|
val repo = FakeItemRepository()
|
|
val viewModel = ItemListViewModel(GetItemsUseCase(repo))
|
|
|
|
viewModel.state.test {
|
|
assertEquals(ItemListState(), awaitItem())
|
|
viewModel.onEvent(ItemListEvent.Load)
|
|
assertTrue(awaitItem().isLoading)
|
|
}
|
|
}
|
|
```
|
|
|
|
## Reference
|
|
|
|
See agents: `kotlin-reviewer`, `kotlin-build-resolver` for Kotlin-specific review and build error resolution.
|